Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding new maintainer @noCharger #3046

Merged
merged 1 commit into from
Sep 26, 2024

Conversation

vamsi-amazon
Copy link
Member

Description

Welcoming new maintianer @noCharger

Related Issues

Resolves #[Issue number to be closed when this PR is merged]

Check List

  • New functionality includes testing.
  • New functionality has been documented.
  • New functionality has javadoc added.
  • New functionality has a user manual doc added.
  • API changes companion pull request created.
  • Commits are signed per the DCO using --signoff.
  • Public documentation issue/PR created.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Vamsi Manohar <[email protected]>
@noCharger
Copy link
Collaborator

@opensearch-project/admin FYI

@gaiksaya
Copy link
Member

Added @noCharger as the maintainer.
Looks like codeowners file is still invalid with below error:

Unknown owner on line 2: make sure @pjfitzgibbons exists and has write access to the repository

Please fix it. You can ask the maintainer if they still wish to be the maintainer. If yes, we can retain the access back else please consider moving them to emeritus section.
Thanks!

@noCharger
Copy link
Collaborator

Added @noCharger as the maintainer. Looks like codeowners file is still invalid with below error:

Unknown owner on line 2: make sure @pjfitzgibbons exists and has write access to the repository

Please fix it. You can ask the maintainer if they still wish to be the maintainer. If yes, we can retain the access back else please consider moving them to emeritus section. Thanks!

Thanks, will create another PR to update it.

@noCharger noCharger merged commit ef5d14a into opensearch-project:main Sep 26, 2024
12 of 14 checks passed
@peterzhuamazon
Copy link
Member

Since it has been a long time since they moved.
You can move them to emeritus:
https://github.com/opensearch-project/.github/blob/main/RESPONSIBILITIES.md#removing-a-maintainer

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants