-
Notifications
You must be signed in to change notification settings - Fork 139
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Spotless] Applying Google Code Format for entire project #22 #2005
[Spotless] Applying Google Code Format for entire project #22 #2005
Conversation
Signed-off-by: Mitchell Gale <[email protected]>
Signed-off-by: Mitchell Gale <[email protected]>
Codecov Report
@@ Coverage Diff @@
## main #2005 +/- ##
=========================================
Coverage 97.30% 97.30%
- Complexity 4622 4623 +1
=========================================
Files 407 407
Lines 11934 11935 +1
Branches 827 828 +1
=========================================
+ Hits 11612 11613 +1
Misses 315 315
Partials 7 7
Flags with carried forward coverage won't be shown. Click here to find out more. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you move left of changes in :legacy
into another PR?
Signed-off-by: Mitchell Gale <[email protected]>
Signed-off-by: Mitchell Gale <[email protected]>
legacy/src/main/java/org/opensearch/sql/legacy/rewriter/nestedfield/From.java
Show resolved
Hide resolved
legacy/src/main/java/org/opensearch/sql/legacy/rewriter/nestedfield/Identifier.java
Show resolved
Hide resolved
… opensearch, plugin, ppl, protocol, sql Signed-off-by: Mitchell Gale <[email protected]>
exclude '**/build/**', '**/build-*/**' | ||
} | ||
importOrder() | ||
// licenseHeader("/*\n" + |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if we aren't going to apply this, we should either have a comment or remove it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good idea, just added a comment that references the blocking issue
Signed-off-by: Mitchell Gale <[email protected]>
Signed-off-by: Mitchell Gale <[email protected]>
09d222b
into
opensearch-project:main
The backport to
To backport manually, run these commands in your terminal: # Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/sql/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/sql/backport-2.x
# Create a new branch
git switch --create backport/backport-2005-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 09d222bd83d6ee1f2ab0933b09499cea92d71b5a
# Push it to GitHub
git push --set-upstream origin backport/backport-2005-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/sql/backport-2.x Then, create a pull request where the |
removing backport-failed since there's a PR merged for 2.x |
Description
Applies spotless on entire project with
**/*.java
Removes checkstyles from project
Issues Resolved
#1101
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.