-
Notifications
You must be signed in to change notification settings - Fork 139
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve processing OpenSearch data types. Fix using subfields for text
type.
#2003
Open
Yury-Fridlyand
wants to merge
4
commits into
opensearch-project:main
Choose a base branch
from
Bit-Quill:integ-add-text-type
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Improve processing OpenSearch data types. Fix using subfields for text
type.
#2003
Yury-Fridlyand
wants to merge
4
commits into
opensearch-project:main
from
Bit-Quill:integ-add-text-type
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…xt` type. (#299) * Add `text` type. Signed-off-by: Yury-Fridlyand <[email protected]> * Simplify implementation. Signed-off-by: Yury-Fridlyand <[email protected]> * Add docs. Signed-off-by: Yury-Fridlyand <[email protected]> * Add IT. Signed-off-by: Yury-Fridlyand <[email protected]> * Fix type resolution in IT. Signed-off-by: Yury-Fridlyand <[email protected]> * Code clean up and comment update. Signed-off-by: Yury-Fridlyand <[email protected]> * Minor clean up. Signed-off-by: Yury-Fridlyand <[email protected]> * Update `ExprType` and tests. Signed-off-by: Yury-Fridlyand <[email protected]> * Minor fix in docs. Signed-off-by: Yury-Fridlyand <[email protected]> * Finalize implementation and tests. Signed-off-by: Yury-Fridlyand <[email protected]> * Smart subfield selection. Signed-off-by: Yury-Fridlyand <[email protected]> * Address PR feedback. Signed-off-by: Yury-Fridlyand <[email protected]> --------- Signed-off-by: Yury-Fridlyand <[email protected]>
Signed-off-by: Yury-Fridlyand <[email protected]>
Signed-off-by: Yury-Fridlyand <[email protected]>
Signed-off-by: Yury-Fridlyand <[email protected]>
Yury-Fridlyand
requested review from
pjfitzgibbons,
ps48,
kavithacm,
derek-ho,
joshuali925,
dai-chen,
YANG-DB,
rupal-bq,
mengweieric,
vamsi-amazon,
Swiddis,
penghuo,
seankao-az,
MaxKsyunz,
anirudha,
forestmvey,
acarbonetto and
GumpacG
as code owners
August 21, 2023 22:48
Codecov Report
@@ Coverage Diff @@
## main #2003 +/- ##
=========================================
Coverage 97.30% 97.30%
- Complexity 4622 4645 +23
=========================================
Files 407 407
Lines 11934 11966 +32
Branches 827 837 +10
=========================================
+ Hits 11612 11644 +32
Misses 315 315
Partials 7 7
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
See doc for technical details: https://github.com/Bit-Quill/opensearch-project-sql/blob/dev-add-text-type/docs/dev/text-type.md
See also this comment describing some changes.
Please, see team review and discussion in Bit-Quill#299.
Issues Resolved
OpenSearchDataType
) though:core
module instead of simplified ones (ExprCoreType
).This unblocks access to important mapping info such as text fields or date formats. This info is required to build proper DSL queries to OpenSearch.
keyword
subfield name.Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.