Optimize the default prompt and make prompt customizable for create anomaly detector tool #399
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: gaobinlong <[email protected]>
gaobinlong
requested review from
b4sjoo,
dhrubo-os,
jngz-es,
model-collapse,
rbhavna,
ylwu-amzn,
zane-neo,
Zhangxunmt,
xinyual,
amitgalitz,
jackiehanyang,
owaiskazi19,
ohltyler,
joshpalis,
dbwiddis,
kaituo,
lezzago,
eirsep,
sbcd90,
zhichao-aws and
joshuali925
as code owners
Signed-off-by: gaobinlong <[email protected]>
Signed-off-by: gaobinlong <[email protected]>
Signed-off-by: gaobinlong <[email protected]>
Signed-off-by: gaobinlong <[email protected]>
gaobinlong
changed the title
gaobinlong
changed the title
Signed-off-by: gaobinlong <[email protected]>
Signed-off-by: gaobinlong <[email protected]>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #399 +/- ##
============================================
- Coverage 81.78% 77.65% -4.14%
- Complexity 193 260 +67
============================================
Files 11 15 +4
Lines 961 1383 +422
Branches 137 197 +60
============================================
+ Hits 786 1074 +288
- Misses 121 232 +111
- Partials 54 77 +23
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
The test case |
xinyual
approved these changes
Sep 29, 2024
zane-neo
reviewed
Sep 29, 2024
Signed-off-by: gaobinlong <[email protected]>
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Sep 29, 2024
…nomaly detector tool (#399) * Optimize the prompt for create anomaly detector tool Signed-off-by: gaobinlong <[email protected]> * Remove whitespace Signed-off-by: gaobinlong <[email protected]> * Make prompt for CreateAnomalyDetectorToll customized Signed-off-by: gaobinlong <[email protected]> * format the code Signed-off-by: gaobinlong <[email protected]> * Fix test failure Signed-off-by: gaobinlong <[email protected]> * fix test failure Signed-off-by: gaobinlong <[email protected]> * Format the code Signed-off-by: gaobinlong <[email protected]> * Add more tests Signed-off-by: gaobinlong <[email protected]> --------- Signed-off-by: gaobinlong <[email protected]> (cherry picked from commit 06a8537) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
zane-neo
pushed a commit
that referenced
this pull request
Sep 29, 2024
…nomaly detector tool (#399) (#419) * Optimize the prompt for create anomaly detector tool * Remove whitespace * Make prompt for CreateAnomalyDetectorToll customized * format the code * Fix test failure * fix test failure * Format the code * Add more tests --------- (cherry picked from commit 06a8537) Signed-off-by: gaobinlong <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Optimize the prompt feed to LLM when executing the CreateAnomalyDetectorTool, the change are:
(long, integer, double, float, short etc.).you should give at most 3 aggregation fields and corresponding aggregation methods, and also make the prompt customizable, users can use their customized prompt.
Related Issues
#337
Check List
--signoff.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.