Subset of permissions check on creation #5012
Open
+431
−90
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Derek Ho <[email protected]>
Signed-off-by: Derek Ho <[email protected]>
Signed-off-by: Derek Ho <[email protected]>
Signed-off-by: Derek Ho <[email protected]>
Signed-off-by: Derek Ho <[email protected]>
…rmissions Signed-off-by: Derek Ho <[email protected]>
Signed-off-by: Derek Ho <[email protected]>
Signed-off-by: Derek Ho <[email protected]>
Signed-off-by: Derek Ho <[email protected]>
Signed-off-by: Derek Ho <[email protected]>
Signed-off-by: Derek Ho <[email protected]>
Signed-off-by: Derek Ho <[email protected]>
Signed-off-by: Derek Ho <[email protected]>
Signed-off-by: Derek Ho <[email protected]>
… write test Signed-off-by: Derek Ho <[email protected]>
Signed-off-by: Derek Ho <[email protected]>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## feature/api-tokens #5012 +/- ##
======================================================
- Coverage 71.46% 71.23% -0.24%
======================================================
Files 334 354 +20
Lines 22552 23322 +770
Branches 3590 3692 +102
======================================================
+ Hits 16117 16613 +496
- Misses 4642 4870 +228
- Partials 1793 1839 +46
|
Signed-off-by: Derek Ho <[email protected]>
Signed-off-by: Derek Ho <[email protected]>
Signed-off-by: Derek Ho <[email protected]>
Signed-off-by: Derek Ho <[email protected]>
derek-ho
requested review from
cwperks,
DarshitChanpura,
nibix,
peternied,
RyanL1997,
reta and
willyborankin
as code owners
…curity into subset Signed-off-by: Derek Ho <[email protected]>
Signed-off-by: Derek Ho <[email protected]>
nibix
reviewed
Feb 5, 2025
| * Validates that the user has the required permissions to create an API token (must be a subset of their own permissions) | ||
| * */ | ||
| @SuppressWarnings("unchecked") | ||
| void validateUserPermissions(List<String> clusterPermissions, List<ApiToken.IndexPermission> indexPermissions) { |
There was a problem hiding this comment.
So, the token they are requesting is validated to be a subset of the permissions available to them in roles.yml, right?
What is supposed to happen if the permissions in roles.yml are later changed, especially if they are reduced?
| // Early return conditions | ||
| if (roles.isEmpty()) { | ||
| throw new OpenSearchException("User does not have any roles"); | ||
| } else if (roles.contains("all_access")) { |
| List<String> roleIndexPerms = indexPermission.getAllowed_actions(); | ||
|
|
||
| // Check if this role's pattern covers the requested pattern | ||
| if (WildcardMatcher.from(rolePatterns).test(requestedPattern)) { |
There was a problem hiding this comment.
Assume that I have a role with the index_pattern /index_[0-9]+/. How can a requestedPattern look like that replicates this pattern?
At the moment, I have doubts that simple pattern matching can be used to support the full pattern semantics.
There was a problem hiding this comment.
This also does not cover alias semantics.
| return DynamicConfigFactory.addStatics(loaded); | ||
| } | ||
|
|
||
| protected void authorizeSecurityAccess(RestRequest request) throws IOException { |
There was a problem hiding this comment.
What do you think about having a dedicated transport action backing the REST action? Then, one would get access control out of the box without needing explicit checks within the action code.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds permission checks around API token creation, and cleans up misc. items from the feature branch, including authorizing API token endpoint properly and stashing the context in order to perform the API token refresh action without explicit permission to do so. This PR is dependent on #4992 to be merged first, and this PR only contains the following changes:
https://github.com/opensearch-project/security/pull/5012/files/aa506e78eb5699d2580e28d4bb0f0060971449e1..e13c055e063ae3e5ee40386a53155e5c65893b58
Issues Resolved
[List any issues this PR will resolve]
Is this a backport? If so, please add backport PR # and/or commits #, and remove
backport-failedlabel from the original PR.Do these changes introduce new permission(s) to be displayed in the static dropdown on the front-end? If so, please open a draft PR in the security dashboards plugin and link the draft PR here
Testing
[Please provide details of testing done: unit testing, integration testing and manual testing]
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.