Skip to content

Commit

Permalink
Exclude time range from report details for Notebooks (#117)
Browse files Browse the repository at this point in the history
* exclude time range check for notebooks reports
Signed-off-by: David Cui <[email protected]>

* use report source identifier over url partial match
Signed-off-by: David Cui <[email protected]>

* add report details fix to release notes
Signed-off-by: David Cui <[email protected]>

* add more bug fixes to release notes
Signed-off-by: David Cui <[email protected]>
  • Loading branch information
davidcui1225 authored Jul 8, 2021
1 parent c0b29d3 commit 72705e2
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 1 deletion.
Original file line number Diff line number Diff line change
Expand Up @@ -211,7 +211,7 @@ export function ReportDetails(props) {
source: reportParams.report_source,
// TODO: we have all data needed, time_from, time_to, time_duration,
// think of a way to better display
time_period: parseTimePeriod(queryUrl),
time_period: (reportParams.report_source !== 'Notebook') ? parseTimePeriod(queryUrl) : '',
defaultFileFormat: coreParams.report_format,
state: state,
reportHeader:
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,9 @@ Compatible with OpenSearch 1.0.0
* Better support sorting for csv report based on saved search ([#86](https://github.com/opensearch-project/dashboards-reports/pull/86))
* bump dependency version ([#101](https://github.com/opensearch-project/dashboards-reports/pull/101))
* fix failed cypress integ-testing ([#106](https://github.com/opensearch-project/dashboards-reports/pull/106))
* Fix notebooks context menu ([#109](https://github.com/opensearch-project/dashboards-reports/pull/109))
* Update context menu download request body after schema change ([#115](https://github.com/opensearch-project/dashboards-reports/pull/115))
* Exclude time range from report details for Notebooks ([#117](https://github.com/opensearch-project/dashboards-reports/pull/117))


### Infrastructure
Expand Down

0 comments on commit 72705e2

Please sign in to comment.