Top n queries configuration page #8
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LilyCaroline17
requested review from
ansjcy,
jainankitk,
deshsidd and
dzane17
as code owners
Signed-off-by: Emily Guo <[email protected]>
Signed-off-by: Emily Guo <[email protected]>
Signed-off-by: Emily Guo <[email protected]>
Signed-off-by: Emily Guo <[email protected]>
Signed-off-by: Emily Guo <[email protected]>
Signed-off-by: Emily Guo <[email protected]>
Signed-off-by: Emily Guo <[email protected]>
Signed-off-by: Emily Guo <[email protected]>
Signed-off-by: Emily Guo <[email protected]>
Signed-off-by: Emily Guo <[email protected]>
Signed-off-by: Emily Guo <[email protected]>
LilyCaroline17
force-pushed
the
topNQueries-Configuration-Page
branch
from
6fb2cff to
ce3aada
Compare
Signed-off-by: Emily Guo <[email protected]>
Signed-off-by: Emily Guo <[email protected]>
Signed-off-by: Emily Guo <[email protected]>
…ine17/query-insights-dashboards into topNQueries-Configuration-Page
Signed-off-by: Emily Guo <[email protected]>
Signed-off-by: Emily Guo <[email protected]>
ansjcy
reviewed
Jul 16, 2024
.gitignore
Outdated
| target | ||
| .eslintcache |
There was a problem hiding this comment.
You might need to remove this once the overview page is merged, otherwise there will be conflicts. The same applies for opensearch_dashboards.json and package.json.
Signed-off-by: Emily Guo <[email protected]>
Signed-off-by: Emily Guo <[email protected]>
Signed-off-by: Emily Guo <[email protected]>
Signed-off-by: Emily Guo <[email protected]>
Signed-off-by: Emily Guo <[email protected]>
Signed-off-by: Emily Guo <[email protected]>
ansjcy
approved these changes
Sep 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Configuration page of top n queries dashboard in the query insights dashboard plugin. User can edit N (number of queries collected within the window size) and the window size (time duration where the top n queries are collected). For N, values have to be between 1 and 100. For window size, time has to be in (1, 5, 10, 30) minutes or (1-24) hours.
Issues Resolved
Related to #5
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.