Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cypress tests for query grouping #55

Merged
merged 1 commit into from
Jan 21, 2025

Conversation

deshsidd
Copy link
Collaborator

Description

Add cypress tests for query grouping feature and update the existing cypress tests where required.

  1. Added a new cypress test for query group details page
  2. Updated cypress test for configuration page
  3. Updated commands.js to invoke grouping APIs for enabling and disabling grouping

Issues Resolved

List any issues this PR will resolve, e.g. Closes [...].

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Siddhant Deshmukh <[email protected]>
@deshsidd deshsidd marked this pull request as ready for review January 21, 2025 19:25
Copy link
Member

@ansjcy ansjcy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ansjcy ansjcy merged commit 626cb15 into opensearch-project:main Jan 21, 2025
9 checks passed
opensearch-trigger-bot bot pushed a commit that referenced this pull request Jan 21, 2025
Signed-off-by: Siddhant Deshmukh <[email protected]>
(cherry picked from commit 626cb15)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
ansjcy pushed a commit that referenced this pull request Jan 21, 2025
(cherry picked from commit 626cb15)

Signed-off-by: Siddhant Deshmukh <[email protected]>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants