Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] User#member is misleading #2

Open
dblock opened this issue Oct 13, 2022 · 0 comments
Open

[BUG] User#member is misleading #2

dblock opened this issue Oct 13, 2022 · 0 comments
Labels
bug Something isn't working

Comments

@dblock
Copy link
Member

dblock commented Oct 13, 2022

What is the bug?

The implementation in

project-tools/lib/github/user.rb

Line 30 in ef4a8ab

def member?
is used to see whether the bio of a user is something that signals membership in the org. The method name is confusing.

What is the expected behavior?

Refactor #member into something like #has_company_bio?.
@dblock dblock added the bug Something isn't working label Oct 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@dblock