Updated opensearch-py to reflect the latest OpenSearch API spec #864
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![opensearch-trigger-bot[bot]](https://avatars.githubusercontent.com/u/80134844?s=60&v=4){kind=small}
opensearch-trigger-bot
bot
requested review from
VachaShah,
dblock,
harshavamsi,
axeoman,
Shephalimittal,
saimedhi and
florianvazelle
as code owners
opensearch-trigger-bot
bot
force-pushed
the
automated-api-update
branch
4 times, most recently
from
6be850b to
65f5f18
Compare
opensearch-trigger-bot
bot
force-pushed
the
automated-api-update
branch
from
65f5f18 to
2afa704
Compare
dblock
requested changes
Dec 11, 2024
| @@ -2451,6 +2451,7 @@ async def search( | |||
| ) | |||
| async def search_shards( | |||
| self, | |||
| body: Any = None, | |||
There was a problem hiding this comment.
This needs to be reordered after index for backwards compat.
There was a problem hiding this comment.
Do you mean after the last arg (i.e. after headers) to make it backward compatible with apps using positional args for this function?
There was a problem hiding this comment.
Not sure what the old signature was without looking, but this change is not backwards compatible.
There was a problem hiding this comment.
The latest commits don' t seem to incorporate the body argument to search_shards, see also #898.
opensearch-trigger-bot
bot
force-pushed
the
automated-api-update
branch
6 times, most recently
from
9f85595 to
e345f66
Compare
opensearch-trigger-bot
bot
force-pushed
the
automated-api-update
branch
2 times, most recently
from
59cdb9a to
4f2ccca
Compare
opensearch-trigger-bot
bot
force-pushed
the
automated-api-update
branch
5 times, most recently
from
8072b3f to
098b030
Compare
opensearch-trigger-bot
bot
force-pushed
the
automated-api-update
branch
3 times, most recently
from
b8e6196 to
126edae
Compare
opensearch-trigger-bot
bot
force-pushed
the
automated-api-update
branch
from
8259464 to
66d987d
Compare
This was referenced Mar 26, 2025
opensearch-trigger-bot
bot
force-pushed
the
automated-api-update
branch
3 times, most recently
from
7e11851 to
128b9ad
Compare
opensearch-trigger-bot
bot
force-pushed
the
automated-api-update
branch
3 times, most recently
from
b1c4c10 to
634effa
Compare
|
Is this till being worked on? It contains the missing |
opensearch-trigger-bot
bot
force-pushed
the
automated-api-update
branch
3 times, most recently
from
700613c to
7cf4bfb
Compare
opensearch-trigger-bot
bot
force-pushed
the
automated-api-update
branch
3 times, most recently
from
cb51d88 to
cd4b1be
Compare
opensearch-trigger-bot
bot
force-pushed
the
automated-api-update
branch
5 times, most recently
from
337eacd to
1a45136
Compare
|
@SimonCW AFAIK no, the spec has a lot of changes, so someone needs to fix tests that are failing here before it can be merged, add OpenSearch 3.0, etc. |
opensearch-trigger-bot
bot
force-pushed
the
automated-api-update
branch
3 times, most recently
from
24a68a3 to
a9e043a
Compare
opensearch-trigger-bot
bot
force-pushed
the
automated-api-update
branch
3 times, most recently
from
b4f14d1 to
e546ed3
Compare
…-05-21) Signed-off-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
opensearch-trigger-bot
bot
force-pushed
the
automated-api-update
branch
from
e546ed3 to
5de337b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated opensearch-py to reflect the latest OpenSearch API spec
Date: 2025-05-22