Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the capability to use RoleBindings instead of ClusterRoleBindings #841

Merged

Conversation

nilushancosta
Copy link
Contributor

Description

This PR introduces a new key to the Helm values named useRoleBindings which when set to true creates Kubernetes RoleBindings instead of ClusterRoleBindings

Issues Resolved

Closes #831

Check List

  • Commits are signed per the DCO using --signoff
  • Unittest added for the new/changed functionality and all unit tests are successful
  • Customer-visible features documented
  • No linter warnings (make lint)

If CRDs are changed:

  • CRD YAMLs updated (make manifests) and also copied into the helm chart
  • Changes to CRDs documented

Please refer to the PR guidelines before submitting this pull request.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@nilushancosta
Copy link
Contributor Author

@swoehrl-mw would you be able to have a look at this PR?

Copy link
Collaborator

@swoehrl-mw swoehrl-mw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it makes more sense to have the ClusterRoleBinding and the RoleBinding in the same file (without the -crb in the filename to make it more generic) and use an if-else-end construct.

@nilushancosta
Copy link
Contributor Author

I think it makes more sense to have the ClusterRoleBinding and the RoleBinding in the same file (without the -crb in the filename to make it more generic) and use an if-else-end construct.

@swoehrl-mw I changed it as requested

Co-authored-by: Sebastian Woehrl <[email protected]>
Signed-off-by: Nilushan Costa <[email protected]>
@swoehrl-mw swoehrl-mw merged commit a6de94c into opensearch-project:main Oct 29, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

[PROPOSAL] Add the capability to use RoleBindings instead of ClusterRoleBindings
2 participants