-
Notifications
You must be signed in to change notification settings - Fork 218
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add the capability to use RoleBindings instead of ClusterRoleBindings #841
Add the capability to use RoleBindings instead of ClusterRoleBindings #841
Conversation
Signed-off-by: Nilushan Costa <[email protected]>
@swoehrl-mw would you be able to have a look at this PR? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it makes more sense to have the ClusterRoleBinding and the RoleBinding in the same file (without the -crb
in the filename to make it more generic) and use an if-else-end construct.
Signed-off-by: Nilushan Costa <[email protected]>
Signed-off-by: Nilushan Costa <[email protected]>
…osta/opensearch-k8s-operator into use-role-bindings-flag
@swoehrl-mw I changed it as requested |
charts/opensearch-operator/templates/opensearch-operator-manager-rolebinding.yaml
Outdated
Show resolved
Hide resolved
charts/opensearch-operator/templates/opensearch-operator-proxy-rolebinding.yaml
Outdated
Show resolved
Hide resolved
Co-authored-by: Sebastian Woehrl <[email protected]> Signed-off-by: Nilushan Costa <[email protected]>
Description
This PR introduces a new key to the Helm values named
useRoleBindings
which when set totrue
creates Kubernetes RoleBindings instead of ClusterRoleBindingsIssues Resolved
Closes #831
Check List
make lint
)If CRDs are changed:
make manifests
) and also copied into the helm chartPlease refer to the PR guidelines before submitting this pull request.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.