-
Notifications
You must be signed in to change notification settings - Fork 273
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
adding healthcheck to docker-compose #3557
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: Tokesh <[email protected]>
Codecov Report
@@ Coverage Diff @@
## main #3557 +/- ##
=======================================
Coverage 91.48% 91.48%
=======================================
Files 181 181
Lines 5369 5369
=======================================
Hits 4912 4912
Misses 457 457 |
Thanks @Tokesh on the contribution here. @prudhvigodithi I am not sure if using curl on docker-compose file is a good way to do healthcheck? |
Thank you for reviewing of pr! But really, i'm not sure about docker-compose, because i can add it everywhere, like in dockerfiles. |
Signed-off-by: Tokesh <[email protected]>
Hey @Tokesh thanks for the update the |
I think so, tho I have not tested on that yet. |
Description
Here few ways how we can add healthcheck, but i add some settings to docker-compose files based on their ports.
I test it in docker ps. Statuses added healthy or unhealthy (problems with SSL certification)
I'm ready to listen all your suggestions and rework this.
Issues Resolved
[#3010]
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.