Skip to content

Commit

Permalink
Changed default to -1 to indicate dimension is a mandatory parameter …
Browse files Browse the repository at this point in the history
…instead of optional

Signed-off-by: Finn Roblin <[email protected]>
  • Loading branch information
finnroblin committed Jul 19, 2024
1 parent 7cbe042 commit d3d6487
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 6 deletions.
4 changes: 1 addition & 3 deletions vectorsearch/indices/train-index.json
Original file line number Diff line number Diff line change
Expand Up @@ -11,9 +11,7 @@
"properties": {
"{{ train_field_name }}": {
"type": "knn_vector",
{%- if target_index_dimension is defined and target_index_dimension %}
"dimension": {{ target_index_dimension }}
{%- endif %}
"dimension": {{ target_index_dimension | default(-1) }}
}
}
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -13,9 +13,7 @@
"training_index": "{{ train_index_name | default('train_index') }}",
"training_field": "{{ train_field_name | default('train_field') }}",
"search_size": "{{ train_search_size | default(10000) }}",
{%- if target_index_dimension is defined and target_index_dimension %}
"dimension": {{ target_index_dimension }},
{%- endif %}
"dimension": {{ target_index_dimension | default(-1) }},
{%- if train_max_vector_count is defined and train_max_vector_count %}
"max_training_vector_count": "{{ train_max_vector_count }}",
{%- endif %}
Expand Down

0 comments on commit d3d6487

Please sign in to comment.