Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ML Connector APIs #764

Merged

Conversation

nathaliellenaa
Copy link
Contributor

@nathaliellenaa nathaliellenaa commented Jan 3, 2025

Description

Added missing ML Connector APIs.

Issues Resolved

Part of opensearch-project/opensearch-py#867.

ML Connector APIs to add

  • GET /_plugins/_ml/connectors/{connector_id}
  • GET /_plugins/_ml/connectors/_search
  • POST /_plugins/_ml/connectors/_search
  • PUT /_plugins/_ml/connectors/{connector_id}

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Copy link
Contributor

github-actions bot commented Jan 3, 2025

Changes Analysis

Commit SHA: 2dd9559
Comparing To SHA: 89aeaa8

API Changes

Summary

├─┬Paths
│ ├──[➕] path (4737:3)
│ ├─┬/_plugins/_ml/connectors/_create
│ │ └─┬POST
│ │   └─┬Requestbody
│ │     └─┬application/json
│ │       └─┬Schema
│ │         └─┬protocol
│ │           ├──[➕] enum (27278:21)
│ │           └──[➕] enum (27279:21)
│ └─┬/_plugins/_ml/connectors/{connector_id}
│   ├──[➕] get (4786:7)
│   └──[➕] put (4801:7)
└─┬Components
  ├──[➕] requestBodies (27409:7)
  ├──[➕] requestBodies (27492:7)
  ├──[➕] responses (30604:7)
  ├──[➕] responses (30693:7)
  ├──[➕] responses (30657:7)
  ├──[➕] parameters (23043:7)
  ├──[➕] parameters (23091:7)
  ├──[➕] schemas (54354:7)
  ├──[➕] schemas (54670:7)
  └─┬ml._common___Source
    ├──[➕] properties (54911:9)
    ├──[➕] properties (54909:9)
    └──[➕] properties (54903:9)

Document Element Total Changes Breaking Changes
paths 5 0
components 12 0
  • Total Changes: 17
  • Additions: 17

Report

The full API changes report is available at: https://github.com/opensearch-project/opensearch-api-specification/actions/runs/12604995766/artifacts/2384698650

API Coverage

Before After Δ
Covered (%) 612 (59.94 %) 616 (60.33 %) 4 (0.39 %)
Uncovered (%) 409 (40.06 %) 405 (39.67 %) -4 (-0.39 %)
Unknown 43 43 0

Copy link
Contributor

github-actions bot commented Jan 4, 2025

Spec Test Coverage Analysis

Total Tested
546 546 (100 %)

Copy link
Collaborator

@Tokesh Tokesh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Great job, Thank you :)

@Tokesh Tokesh merged commit db45550 into opensearch-project:main Jan 4, 2025
42 checks passed
@nathaliellenaa nathaliellenaa deleted the add-ml-connector-api branch January 9, 2025 21:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants