Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed schema validation for invalid properties in retry configuration. #758

Merged

Conversation

nathaliellenaa
Copy link
Contributor

@nathaliellenaa nathaliellenaa commented Dec 31, 2024

Description

Prevents invalid properties for being added in retry configuration in the test story.

Issues Resolved

Resolve #757

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Copy link
Contributor

github-actions bot commented Dec 31, 2024

Changes Analysis

Commit SHA: a52e3fa
Comparing To SHA: a3849b4

API Changes

Summary

NO CHANGES

Report

The full API changes report is available at: https://github.com/opensearch-project/opensearch-api-specification/actions/runs/12564458381/artifacts/2375214252

API Coverage

Before After Δ
Covered (%) 609 (59.65 %) 609 (59.65 %) 0 (0 %)
Uncovered (%) 412 (40.35 %) 412 (40.35 %) 0 (0 %)
Unknown 43 43 0

Signed-off-by: Nathalie Jonathan <[email protected]>
@dblock
Copy link
Member

dblock commented Dec 31, 2024

Since this fixes a bug, please add a test.

@dblock
Copy link
Member

dblock commented Jan 2, 2025

Nice and clean.

@dblock dblock merged commit 24872ec into opensearch-project:main Jan 2, 2025
11 checks passed
@nathaliellenaa nathaliellenaa deleted the fix-schema-validation branch January 2, 2025 17:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Schema validation fails to prevent invalid 'until' property in retry configuration
2 participants