Added _ml/agents and ml/connectors specs
#585
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
September 18, 2024 10:03
…with test Signed-off-by: Junwei Dai <[email protected]>
Signed-off-by: Junwei Dai <[email protected]>
junweid62
requested review from
dblock,
harshavamsi,
sachetalva,
nhtruong,
Xtansia,
VachaShah,
Tokesh and
aabeshov
as code owners
Changes AnalysisCommit SHA: 030944a API ChangesSummary
ReportThe full API changes report is available at: https://github.com/opensearch-project/opensearch-api-specification/actions/runs/10945790110/artifacts/1954430061 API Coverage
|
Signed-off-by: Junwei Dai <[email protected]>
Spec Test Coverage Analysis
|
dbwiddis
approved these changes
Sep 19, 2024
Comment on lines
+180
to
+187
| required: | ||
| - actions | ||
| - credential | ||
| - description | ||
| - name | ||
| - parameters | ||
| - protocol | ||
| - version |
There was a problem hiding this comment.
This is exactly the data we're going to want to pull programmatically to validate our templates. Glad to see it being added!
dblock
requested changes
Sep 19, 2024
Co-authored-by: Daniel (dB.) Doubrovkine <[email protected]> Signed-off-by: Junwei Dai <[email protected]>
Signed-off-by: Junwei Dai <[email protected]>
Signed-off-by: Junwei Dai <[email protected]>
dblock
approved these changes
Sep 20, 2024
dblock
added a commit
to dblock/opensearch-api-specification
that referenced
this pull request
Sep 23, 2024
* Add Ml api Spec , /connector/_register and /connector/{connector_id} with test
Signed-off-by: Junwei Dai <[email protected]>
* Add Ml api Spec , /agents/_register and /agents/{agent_id} with test
Signed-off-by: Junwei Dai <[email protected]>
* fix: agent_id error
Signed-off-by: Junwei Dai <[email protected]>
* Update CHANGELOG.md
Co-authored-by: Daniel (dB.) Doubrovkine <[email protected]>
Signed-off-by: Junwei Dai <[email protected]>
* Readded empty line
Signed-off-by: Junwei Dai <[email protected]>
---------
Signed-off-by: Junwei Dai <[email protected]>
Signed-off-by: Junwei Dai <[email protected]>
Co-authored-by: Junwei Dai <[email protected]>
Co-authored-by: Daniel (dB.) Doubrovkine <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR documents a subset of the ML Commons APIs consumed by the Flow Framework client.
Previously covered API specs (in other PRs):
POST /_plugins/_ml/model_groups/_registerPOST /_plugins/_ml/models/_registerDELETE /_plugins/_ml/models/{model_id}POST /_plugins/_ml/models/{model_id}/_deployPOST /_plugins/_ml/models/{model_id}/_undeployNew API specs added in this PR:
POST /_plugins/_ml/agents/_registerDELETE /_plugins/_ml/agents/{agent_id}POST /_plugins/_ml/connectors/_createDELETE /_plugins/_ml/connectors/{connector_id}Issues Resolved
Part of #228
Task 3 of #833
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.