Skip to content

Commit

Permalink
chore: added changelog and getUrl method
Browse files Browse the repository at this point in the history
Signed-off-by: Tokesh <[email protected]>
  • Loading branch information
Tokesh committed Jan 7, 2025
1 parent f561040 commit fdfb6db
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 0 deletions.
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -45,6 +45,7 @@ Inspired from [Keep a Changelog](https://keepachangelog.com/en/1.0.0/)
- Added `GET /_plugins/_ml/connectors/{connector_id}`, `_search`, `POST /_plugins/_ml/connectors/_search`, and `PUT /_plugins/_ml/connectors/{connector_id}` ([#764](https://github.com/opensearch-project/opensearch-api-specification/pull/764))
- Added the ability to skip an individual chapter test ([#765](https://github.com/opensearch-project/opensearch-api-specification/pull/765))
- Added uploading of test spec logs ([#767](https://github.com/opensearch-project/opensearch-api-specification/pull/767))
- Added generation of file for Postman ([#770](https://github.com/opensearch-project/opensearch-api-specification/pull/770))

### Removed
- Removed unsupported `_common.mapping:SourceField`'s `mode` field and associated `_common.mapping:SourceFieldMode` enum ([#652](https://github.com/opensearch-project/opensearch-api-specification/pull/652))
Expand Down
5 changes: 5 additions & 0 deletions tools/src/OpenSearchHttpClient.ts
Original file line number Diff line number Diff line change
Expand Up @@ -221,6 +221,11 @@ export class OpenSearchHttpClient {
}
}

getUrl(): string | undefined {

Check failure on line 224 in tools/src/OpenSearchHttpClient.ts

View workflow job for this annotation

GitHub Actions / lint

Class Method name `getUrl` must match one of the following formats: snake_case
if(this._opts != null && !this._opts.url) return this._opts.url ;

Check failure on line 225 in tools/src/OpenSearchHttpClient.ts

View workflow job for this annotation

GitHub Actions / lint

Expected space(s) after "if"

Check failure on line 225 in tools/src/OpenSearchHttpClient.ts

View workflow job for this annotation

GitHub Actions / lint

Unexpected nullable string value in conditional. Please handle the nullish/empty cases explicitly
return DEFAULT_URL;
}

async request<T = any, R = AxiosResponse<T>, D = any>(config: AxiosRequestConfig<D>): Promise<R> {
return await this._axios.request(config)
}
Expand Down

0 comments on commit fdfb6db

Please sign in to comment.