Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update statefulset to inlcude verbose PVC reference #654

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

ritzk
Copy link

@ritzk ritzk commented Feb 21, 2025

Description

The issue is that the verbose reference is added once ArgoCD applies the chart to cluster. This results in ArgoCD thinking there is a diff, when there is none. This can be solved by adding a patch which adds the verbose reference.

Issues Resolved

n/a

Check List

  • Commits are signed per the DCO using --signoff

For any changes to files within Helm chart directories:

  • Helm chart version bumped
  • Helm chart CHANGELOG.md updated to reflect change

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Similar to bitnami/charts#17140

@DandyDeveloper
Copy link
Collaborator

@ritzk Please do DCO Checks and check the linting output.

@ritzk
Copy link
Author

ritzk commented Feb 21, 2025

@ritzk Please do DCO Checks and check the linting output.

@DandyDeveloper lint failed due to n/w issues on the action runner.

→ ct lint
Linting charts...

------------------------------------------------------------------------------------------------------------------------
 Charts to be processed:
------------------------------------------------------------------------------------------------------------------------
 opensearch => (version: "2.31.1", path: "charts/opensearch")
------------------------------------------------------------------------------------------------------------------------

Linting chart "opensearch => (version: \"2.31.1\", path: \"charts/opensearch\")"
Checking chart "opensearch => (version: \"2.31.1\", path: \"charts/opensearch\")" for a version bump...
Old chart version: 2.31.0
New chart version: 2.31.1
Chart version ok.
Validating charts/opensearch/Chart.yaml...
Validation success! 👍
Validating maintainers...

Linting chart with values file "charts/opensearch/ci/ci-ingress-class-name-values.yaml"...

==> Linting charts/opensearch
[INFO] Chart.yaml: icon is recommended

1 chart(s) linted, 0 chart(s) failed

Linting chart with values file "charts/opensearch/ci/ci-rbac-enabled-values.yaml"...

==> Linting charts/opensearch
[INFO] Chart.yaml: icon is recommended

1 chart(s) linted, 0 chart(s) failed

Linting chart with values file "charts/opensearch/ci/ci-values.yaml"...

==> Linting charts/opensearch
[INFO] Chart.yaml: icon is recommended

1 chart(s) linted, 0 chart(s) failed

------------------------------------------------------------------------------------------------------------------------
 ✔︎ opensearch => (version: "2.31.1", path: "charts/opensearch")
------------------------------------------------------------------------------------------------------------------------
All charts linted successfully

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

2 participants