Allow overriding of pathType in ingress rules to support ImplementationSpecific
#471
+9
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ationSpecific` Depending on implementation of ingressClass, hardcoded value `Prefix` for `pathType` of rules won't work and `ImplementationSpecific` should be specified instead. This change add a new parameter for both helm charts for `opensearch` and `opensearch-dashboards` * `opensearch` gets `pathType: Prefix` along with the existing `path: /` in `value.yaml` * `opensearch-dashboards` gets `pathType: Prefix` in `ingress.hosts.paths` array and defaults to `Prefix` in the template `ingress.yaml` and the default rule specified in `values.yaml`. Signed-off-by: seveneves <[email protected]>
seveneves
requested review from
bbarani,
TheAlgo,
DandyDeveloper,
peterzhuamazon,
prudhvigodithi and
gaiksaya
as code owners
|
@peterzhuamazon @prudhvigodithi @TheAlgo Can you please review this PR and provide your feedback? |
|
@bbarani @peterzhuamazon @prudhvigodithi @TheAlgo Hi, this PR has been open for a while now, is there any way we can progress with it? Thanks in advance |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Depending on implementation of ingressClass, hardcoded value
PrefixforpathTypeof rules won't work andImplementationSpecificshould be specified instead.This change adds a new parameter for both helm charts for
opensearchandopensearch-dashboardsopensearchaddspathType: Prefixalong with the existingpath: /invalue.yamlopensearch-dashboardsaddspathType: Prefixiningress.hosts.pathsarray and defaults toPrefixin the templateingress.yamland the default rule specified invalues.yaml.Issues Resolved
No issue created
Check List
For any changes to files within Helm chart directories:
CHANGELOG.mdupdated to reflect changeBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.