Improve Jira logging #5351
Open
Improve Jira logging #5351
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Maxwell Brown <[email protected]>
Galactus22625
requested review from
sb2k16,
chenqi0805,
engechas,
san81,
srikanthjg,
graytaylor0,
dinujoh,
kkondaka,
KarstenSchnitter,
dlvenable and
oeyh
as code owners
Signed-off-by: Maxwell Brown <[email protected]>
san81
reviewed
Jan 23, 2025
| @@ -75,7 +75,7 @@ public LeaderProgressState convertToPartitionState(final String serializedPartit | |||
| try { | |||
| return objectMapper.readValue(serializedPartitionProgressState, LeaderProgressState.class); | |||
| } catch (final JsonProcessingException e) { | |||
| LOG.error("Unable to convert string to partition progress state class ", e); | |||
| LOG.error("Unable to convert string to partition progress state class due to {}", e.getMessage()); | |||
There was a problem hiding this comment.
Can we print the String partition progress state as well here?
Signed-off-by: Maxwell Brown <[email protected]>
san81
previously approved these changes
Jan 23, 2025
dlvenable
requested changes
Jan 23, 2025
| @@ -38,7 +38,7 @@ public static InetAddress getInetAddress(String url) { | |||
| try { | |||
| return InetAddress.getByName(new URL(url).getHost()); | |||
| } catch (UnknownHostException | MalformedURLException e) { | |||
| log.error(INVALID_URL, e); | |||
| log.error(INVALID_URL + " : {}", url); | |||
There was a problem hiding this comment.
Suggested change
| log.error(INVALID_URL + " : {}", url); | |
| log.error("{}: {}", INVALID_URL, url); |
| authConfig.renewCredentials(); | ||
| } else if (statusCode == HttpStatus.TOO_MANY_REQUESTS) { | ||
| log.error(NOISY, "Hitting API rate limit. Backing off with sleep timer.", ex); | ||
| log.error("Hitting API rate limit. Backing off with sleep timer."); |
There was a problem hiding this comment.
I think its not needed because it's only one line and retries are capped at 6
| log.error(NOISY, "Hitting API rate limit. Backing off with sleep timer.", ex); | ||
| log.error("Hitting API rate limit. Backing off with sleep timer."); | ||
| } else { | ||
| log.error(NOISY, "Exception: ", ex); |
There was a problem hiding this comment.
Provide a more useful exception line here. Also, we know that this is an HTTP client status code when we get here. It is just one we don't know.
For example:
log.error(NOISY, "Received an unexpected status code when requesting from Jira. statusCode={}", statusCode);
| @@ -119,19 +119,21 @@ private <T> ResponseEntity<T> invokeRestApi(URI uri, Class<T> responseType) thro | |||
| } catch (HttpClientErrorException ex) { | |||
There was a problem hiding this comment.
What happens if another type of exception is thrown here? This will throw it back. Do we have other error handling for that?
Also, we appear to not have error handling for 5xx errors.
There was a problem hiding this comment.
added error logging for unknown exception, added error handling for some 5xx errors
Signed-off-by: Maxwell Brown <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
prevent over logging stack traces in jira source
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.