Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

github actions/ artifacts v3 to v4 #5339

Merged
merged 2 commits into from
Jan 16, 2025
Merged

github actions/ artifacts v3 to v4 #5339

merged 2 commits into from
Jan 16, 2025

Conversation

Galactus22625
Copy link
Member

@Galactus22625 Galactus22625 commented Jan 16, 2025 •
edited
Loading

Description

Github has deprecated actions/upload-artifact@v3 and actions/download-artifact@v3.
Updating integration tests for kafka and kineses to version4.

OpenSearchSink and gradle.yml integration tests are updated again in PR #5273 , might cause merge conflicts

Check List

  • New functionality includes testing.
  • New functionality has a documentation issue. Please link to it in this PR.
    • New functionality has javadoc added
  • Commits are signed with a real name per the DCO

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@Galactus22625 Galactus22625 marked this pull request as draft January 16, 2025 18:56
@Galactus22625 Galactus22625 marked this pull request as ready for review January 16, 2025 19:06
oeyh
oeyh reviewed Jan 16, 2025
View reviewed changes
Copy link
Collaborator

@oeyh oeyh left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for fixing it! Looks like there're a few other workflows that are still using v3 and causing workflow failures, e.g. gradle.yml. Can you update them as well?

@Galactus22625
Copy link
Member Author

Thank you for fixing it! Looks like there're a few other workflows that are still using v3 and causing workflow failures, e.g. gradle.yml. Can you update them as well?

I had fixed them in a different pr that didn't get merged yet. Will fix them here as well.

san81
san81 approved these changes Jan 16, 2025
View reviewed changes
Copy link
Collaborator

@san81 san81 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for taking care of this change

@oeyh oeyh merged commit 41e3227 into opensearch-project:main Jan 16, 2025
42 of 47 checks passed
@Galactus22625 Galactus22625 deleted the update-artificats-version branch January 16, 2025 19:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oeyh oeyh oeyh approved these changes

@san81 san81 san81 approved these changes

@sb2k16 sb2k16 Awaiting requested review from sb2k16 sb2k16 is a code owner

@chenqi0805 chenqi0805 Awaiting requested review from chenqi0805 chenqi0805 is a code owner

@engechas engechas Awaiting requested review from engechas engechas is a code owner

@graytaylor0 graytaylor0 Awaiting requested review from graytaylor0 graytaylor0 is a code owner

@dinujoh dinujoh Awaiting requested review from dinujoh dinujoh is a code owner

@kkondaka kkondaka Awaiting requested review from kkondaka kkondaka is a code owner

@KarstenSchnitter KarstenSchnitter Awaiting requested review from KarstenSchnitter KarstenSchnitter is a code owner

@dlvenable dlvenable Awaiting requested review from dlvenable dlvenable is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Galactus22625 @san81 @oeyh