Update renewed Jira refresh token back to the secrets store #5324
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… plugins to get access to their underlying aws secrets store member to be able to update if needed Signed-off-by: Santhosh Gandhe <[email protected]>
…ecrets store Signed-off-by: Santhosh Gandhe <[email protected]>
Signed-off-by: Santhosh Gandhe <[email protected]>
san81
changed the title
… used for refreshToken Signed-off-by: Santhosh Gandhe <[email protected]>
Signed-off-by: Santhosh Gandhe <[email protected]>
san81
requested review from
sb2k16,
chenqi0805,
engechas,
graytaylor0,
dinujoh,
kkondaka,
KarstenSchnitter,
dlvenable and
oeyh
as code owners
chenqi0805
reviewed
Jan 13, 2025
...plugins/aws-plugin/src/main/java/org/opensearch/dataprepper/plugins/aws/SecretsSupplier.java
Show resolved
Hide resolved
...ugin/src/main/java/org/opensearch/dataprepper/plugins/aws/AwsSecretManagerConfiguration.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Santhosh Gandhe <[email protected]>
dlvenable
requested changes
Jan 14, 2025
...-prepper-api/src/main/java/org/opensearch/dataprepper/model/plugin/PluginConfigVariable.java
Outdated
Show resolved
Hide resolved
...-prepper-api/src/main/java/org/opensearch/dataprepper/model/plugin/PluginConfigVariable.java
Outdated
Show resolved
Hide resolved
...epper-plugin-framework/src/main/java/org/opensearch/dataprepper/plugin/VariableExpander.java
Show resolved
Hide resolved
...gins/aws-plugin/src/main/java/org/opensearch/dataprepper/plugins/aws/AwsSecretsSupplier.java
Show resolved
Hide resolved
...-prepper-api/src/main/java/org/opensearch/dataprepper/model/plugin/PluginConfigVariable.java
Show resolved
Hide resolved
...test/java/org/opensearch/dataprepper/plugins/source/jira/utils/TestUtilForPrivateFields.java
Outdated
Show resolved
Hide resolved
...r-api/src/main/java/org/opensearch/dataprepper/model/plugin/PluginConfigValueTranslator.java
Show resolved
Hide resolved
...-prepper-api/src/main/java/org/opensearch/dataprepper/model/plugin/PluginConfigVariable.java
Show resolved
Hide resolved
...-prepper-api/src/main/java/org/opensearch/dataprepper/model/plugin/PluginConfigVariable.java
Show resolved
Hide resolved
...src/test/java/org/opensearch/dataprepper/plugins/aws/AwsSecretsPluginConfigVariableTest.java
Outdated
Show resolved
Hide resolved
…l test coverage Signed-off-by: Santhosh Gandhe <[email protected]>
Signed-off-by: Santhosh Gandhe <[email protected]>
Signed-off-by: Santhosh Gandhe <[email protected]>
Signed-off-by: Santhosh Gandhe <[email protected]>
Signed-off-by: Santhosh Gandhe <[email protected]>
Signed-off-by: Santhosh Gandhe <[email protected]>
…set that helps with enforcing idempotency while updating the secret store multiple times Signed-off-by: Santhosh Gandhe <[email protected]>
dlvenable
requested changes
Jan 16, 2025
...-prepper-api/src/main/java/org/opensearch/dataprepper/model/plugin/PluginConfigVariable.java
Show resolved
Hide resolved
...api/src/main/java/org/opensearch/dataprepper/model/plugin/FailedToUpdateSecretException.java
Outdated
Show resolved
Hide resolved
...-prepper-api/src/main/java/org/opensearch/dataprepper/model/plugin/PluginConfigVariable.java
Outdated
Show resolved
Hide resolved
...gins/aws-plugin/src/main/java/org/opensearch/dataprepper/plugins/aws/AwsSecretsSupplier.java
Show resolved
Hide resolved
.../src/main/java/org/opensearch/dataprepper/plugins/source/jira/rest/auth/JiraOauthConfig.java
Show resolved
Hide resolved
...aws-plugin/src/main/java/org/opensearch/dataprepper/plugins/aws/AwsPluginConfigVariable.java
Show resolved
Hide resolved
Signed-off-by: Santhosh Gandhe <[email protected]>
Signed-off-by: Santhosh Gandhe <[email protected]>
Signed-off-by: Santhosh Gandhe <[email protected]>
chenqi0805
approved these changes
Jan 16, 2025
dlvenable
approved these changes
Jan 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In Jira OAuth2 based authentication, if one node renew the refresh token, others are not aware of the renewed refreshed token. This PR enables a way to write the renewed token back into the secret store so that other OCU nodes can pick up the renewed token and continue their execution. The changes introduced in this PR are
Issues Resolved
Resolves #[Issue number to be closed when this PR is merged]
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.