Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add custom result index lifecycle management #1232

Conversation

jackiehanyang
Copy link
Collaborator

Description

Add custom result index lifecycle management. AD doesn't provide customer the ability to manage their custom result index lifecycle before, customers can only go to ISM to manage it. Now we allow customer to add index lifecycle management conditions at frontend, and we manage them inside AD

Issues Resolved

#1213

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Copy link

codecov bot commented Jun 10, 2024

Codecov Report

Attention: Patch coverage is 80.85106% with 9 lines in your changes missing coverage. Please review.

Project coverage is 71.45%. Comparing base (4d400e3) to head (ce85d43).
Report is 2 commits behind head on main.

Current head ce85d43 differs from pull request most recent head d03ed70

Please upload reports for the commit d03ed70 to get more accurate results.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##               main    #1232      +/-   ##
============================================
- Coverage     71.48%   71.45%   -0.03%     
- Complexity     4888     4890       +2     
============================================
  Files           518      518              
  Lines         22933    22962      +29     
  Branches       2260     2265       +5     
============================================
+ Hits          16394    16408      +14     
- Misses         5496     5500       +4     
- Partials       1043     1054      +11     
Flag Coverage Δ
plugin 71.45% <80.85%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...a/org/opensearch/ad/indices/ADIndexManagement.java 81.66% <ø> (-0.31%) ⬇️
...arch/forecast/indices/ForecastIndexManagement.java 56.70% <ø> (ø)
.../java/org/opensearch/ad/model/AnomalyDetector.java 86.46% <71.42%> (-0.56%) ⬇️
...opensearch/timeseries/indices/IndexManagement.java 71.95% <82.50%> (+2.82%) ⬆️

... and 8 files with indirect coverage changes

@jackiehanyang jackiehanyang force-pushed the customResultIndexConditions branch 2 times, most recently from 627a541 to d03ed70 Compare June 11, 2024 18:35
@jackiehanyang jackiehanyang merged commit 918c48a into opensearch-project:main Jun 11, 2024
48 checks passed
opensearch-trigger-bot bot pushed a commit that referenced this pull request Jun 11, 2024
* add custom result index lifecycle management

Signed-off-by: Jackie Han <[email protected]>

* only parse number value for custom result index conditions fields

Signed-off-by: Jackie Han <[email protected]>

* make custom result index no hidden index

Signed-off-by: Jackie Han <[email protected]>

---------

Signed-off-by: Jackie Han <[email protected]>
(cherry picked from commit 918c48a)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
jackiehanyang pushed a commit that referenced this pull request Jun 11, 2024
* add custom result index lifecycle management



* only parse number value for custom result index conditions fields



* make custom result index no hidden index



---------


(cherry picked from commit 918c48a)

Signed-off-by: Jackie Han <[email protected]>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants