[Backport 2.13] Include server.basepath config in the manage notifications channel Url #917
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![opensearch-trigger-bot[bot]](https://avatars.githubusercontent.com/u/80134844?s=60&v=4){kind=small}
#914) * refactored code to always include the server.basepath for manager channels url Signed-off-by: Amardeepsingh Siglani <[email protected]> * refactored code Signed-off-by: Amardeepsingh Siglani <[email protected]> --------- Signed-off-by: Amardeepsingh Siglani <[email protected]> (cherry picked from commit 1ac71bc) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 2.13 #917 +/- ##
==========================================
- Coverage 48.74% 48.73% -0.02%
==========================================
Files 236 236
Lines 6839 6843 +4
Branches 995 995
==========================================
+ Hits 3334 3335 +1
- Misses 3502 3505 +3
Partials 3 3 ☔ View full report in Codecov by Sentry. |
amsiglan
approved these changes
Apr 4, 2024
riysaxen-amzn
approved these changes
Apr 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport 1ac71bc from #914.