[Backport 2.15] [BUG] Change time format to UTC in notification message preview (#1183) #1185
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…search-project#1183) * fix: change notification preview message to have time in UTC format. fix an improper import Signed-off-by: vikhy-aws <[email protected]> * fix: add unit tests. change timezone to UTC Signed-off-by: vikhy-aws <[email protected]> * fix: remove log statements Signed-off-by: vikhy-aws <[email protected]> * fix: update timeout for loadSampleEcommerceData to 60secs to handle failing cypress test Signed-off-by: vikhy-aws <[email protected]> * fix: update timeout for monitor creation to 60secs to handle failing cypress test Signed-off-by: vikhy-aws <[email protected]> * fix: update timeout for monitor creation to 60secs to handle failing cypress test Signed-off-by: vikhy-aws <[email protected]> * fix: revert timeout increases. Handle monitors page load properly. Signed-off-by: vikhy-aws <[email protected]> * fix: revert changes to timeouts Signed-off-by: vikhy-aws <[email protected]> * fix: increase timeouts to ensure proper loading of pages Signed-off-by: vikhy-aws <[email protected]> --------- Signed-off-by: vikhy-aws <[email protected]>
Signed-off-by: vikhy-aws <[email protected]>
Signed-off-by: vikhy-aws <[email protected]>
vikhy-aws
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 2.15 #1185 +/- ##
=======================================
Coverage ? 48.50%
=======================================
Files ? 237
Lines ? 7024
Branches ? 1026
=======================================
Hits ? 3407
Misses ? 3614
Partials ? 3 ☔ View full report in Codecov by Sentry. |
Signed-off-by: vikhy-aws <[email protected]>
(cherry picked from commit 370cad8) Signed-off-by: AWSHurneyt <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
AWSHurneyt
approved these changes
Jan 10, 2025
riysaxen-amzn
approved these changes
Jan 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport 47800b7 to 2.15.
Link to original PR - #1183
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.