Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flight stream impl #17313

Draft
wants to merge 32 commits into
base: main
Choose a base branch
from
Draft
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
32 commits
Select commit Hold shift + click to select a range
dc0ee0c
Arrow Flight Server bootstrap logic
rishabhmaurya Jan 6, 2025
58549e8
interim changes - integration with Auxiliary Transport
rishabhmaurya Jan 14, 2025
4e41606
changes to use grpc-netty-shaded
rishabhmaurya Jan 16, 2025
1b05063
Update javadoc
rishabhmaurya Jan 16, 2025
a1a0ff2
fix the shaded dependencies
rishabhmaurya Jan 20, 2025
8ac21ef
Move arrow-flight-rpc from module to plugin
rishabhmaurya Jan 20, 2025
4cad014
remove unnecessary imports
rishabhmaurya Jan 20, 2025
55c30b7
rebase fixes
rishabhmaurya Jan 20, 2025
e596a87
Fix permissions and other runtime issues
rishabhmaurya Jan 21, 2025
721e7ff
Remove StreamManagerWrapper and Node.java changes from PR
rishabhmaurya Jan 21, 2025
6a4e1a5
Fix permissions for test
rishabhmaurya Jan 21, 2025
b0043f7
remove testGetFlightClientLocationExecutionError as thread interrupti…
rishabhmaurya Jan 21, 2025
101c938
Fix the issue with single node ClientManager
rishabhmaurya Jan 23, 2025
7ada057
Fix flight server integ test on unix machine
rishabhmaurya Jan 24, 2025
c818346
suppress JSM removal warning
rishabhmaurya Jan 24, 2025
f49a2a5
Fix security policy and FlightClientManagerTests
rishabhmaurya Jan 25, 2025
846eb4d
remove StreamManagerWrapper from the PR
rishabhmaurya Jan 26, 2025
e836e1c
Set multi-release in manifest while shadowing arrow-memory-shaded
rishabhmaurya Jan 27, 2025
ac55f9a
Disable jacocoReport for shaded projects
rishabhmaurya Jan 27, 2025
461e3b0
Remove multi version classes from arrow-memory-shaded
rishabhmaurya Jan 28, 2025
d815048
Address the PR comments
rishabhmaurya Jan 28, 2025
a5f1e31
Move the arrow-memory-shaded and flight within flight-rpc plugin
rishabhmaurya Jan 28, 2025
e708365
Move the arrow-memory-shaded and flight within flight-rpc plugin
rishabhmaurya Jan 28, 2025
91b0d9f
Detach SPI from Apache Arrow (not needed at the moment), drop all sha…
reta Jan 29, 2025
72589b4
Rebase and other minor refactoring
rishabhmaurya Feb 8, 2025
2af7d35
Address PR comments - majorly move away from grpc-netty-shaded
rishabhmaurya Feb 10, 2025
313ebb2
remove arrow flight, client from codecov as the package is non opense…
rishabhmaurya Feb 10, 2025
727e3b3
change compileOnly to implementation dep for arrow-spi
rishabhmaurya Feb 10, 2025
3688ee9
Rebase from main and fixes related to netty version bump
rishabhmaurya Feb 11, 2025
51cb44e
Flight producer changes
rishabhmaurya Feb 8, 2025
14bb126
Fix security policy
rishabhmaurya Feb 9, 2025
cf1733f
Fix javadoc errors
rishabhmaurya Feb 10, 2025
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG-3.0.md
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
- Views, simplify data access and manipulation by providing a virtual layer over one or more indices ([#11957](https://github.com/opensearch-project/OpenSearch/pull/11957))
- Added pull-based Ingestion (APIs, for ingestion source, a Kafka plugin, and IngestionEngine that pulls data from the ingestion source) ([#16958](https://github.com/opensearch-project/OpenSearch/pull/16958))
- Added ConfigurationUtils to core for the ease of configuration parsing [#17223](https://github.com/opensearch-project/OpenSearch/pull/17223)
- Arrow Flight RPC plugin with server bootstrap logic ([#16962](https://github.com/opensearch-project/OpenSearch/pull/16962))

### Dependencies
- Update Apache Lucene to 10.1.0 ([#16366](https://github.com/opensearch-project/OpenSearch/pull/16366))
Expand Down
1 change: 1 addition & 0 deletions codecov.yml
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@ codecov:
ignore:
- "test"
- "benchmarks"
- "plugins/arrow-flight-rpc/**/org/apache/arrow/flight/**"

coverage:
precision: 2
Expand Down
2 changes: 1 addition & 1 deletion gradle/libs.versions.toml
Original file line number Diff line number Diff line change
Expand Up @@ -82,7 +82,7 @@ opentelemetry = "1.46.0"
opentelemetrysemconv = "1.29.0-alpha"

# arrow dependencies
arrow = "17.0.0"
arrow = "18.1.0"
flatbuffers = "2.0.0"

[libraries]
Expand Down
70 changes: 1 addition & 69 deletions libs/arrow-spi/build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -10,79 +10,11 @@
*/

testingConventions.enabled = false

dependencies {
api project(':libs:opensearch-core')
api "org.apache.arrow:arrow-vector:${versions.arrow}"
api "org.apache.arrow:arrow-format:${versions.arrow}"
api "org.apache.arrow:arrow-memory-core:${versions.arrow}"
runtimeOnly "org.apache.arrow:arrow-memory-netty-buffer-patch:${versions.arrow}"
runtimeOnly "org.apache.arrow:arrow-memory-netty:${versions.arrow}"
runtimeOnly "io.netty:netty-buffer:${versions.netty}"
runtimeOnly "io.netty:netty-common:${versions.netty}"

runtimeOnly "com.google.flatbuffers:flatbuffers-java:${versions.flatbuffers}"
runtimeOnly "org.slf4j:slf4j-api:${versions.slf4j}"
runtimeOnly "com.fasterxml.jackson.core:jackson-databind:${versions.jackson}"
api "com.fasterxml.jackson.core:jackson-annotations:${versions.jackson}"

implementation "commons-codec:commons-codec:${versions.commonscodec}"
}

tasks.named('forbiddenApisMain').configure {
replaceSignatureFiles 'jdk-signatures'
}

tasks.named('thirdPartyAudit').configure {
ignoreMissingClasses(
// Logging frameworks
'org.apache.commons.logging.Log',
'org.apache.commons.logging.LogFactory',
'org.apache.log4j.Level',
'org.apache.log4j.Logger',
'org.slf4j.impl.StaticLoggerBinder',
'org.slf4j.impl.StaticMDCBinder',
'org.slf4j.impl.StaticMarkerBinder',

// Reactor BlockHound
'reactor.blockhound.BlockHound$Builder',
'reactor.blockhound.integration.BlockHoundIntegration'
)

ignoreViolations(
"io.netty.util.internal.PlatformDependent0",
"io.netty.util.internal.PlatformDependent0\$1",
"io.netty.util.internal.PlatformDependent0\$2",
"io.netty.util.internal.PlatformDependent0\$3",
"io.netty.util.internal.PlatformDependent0\$4",
"io.netty.util.internal.PlatformDependent0\$6",
"io.netty.util.internal.shaded.org.jctools.queues.BaseLinkedQueueConsumerNodeRef",
"io.netty.util.internal.shaded.org.jctools.queues.BaseLinkedQueueProducerNodeRef",
"io.netty.util.internal.shaded.org.jctools.queues.BaseMpscLinkedArrayQueueColdProducerFields",
"io.netty.util.internal.shaded.org.jctools.queues.BaseMpscLinkedArrayQueueConsumerFields",
"io.netty.util.internal.shaded.org.jctools.queues.BaseMpscLinkedArrayQueueProducerFields",
"io.netty.util.internal.shaded.org.jctools.queues.LinkedQueueNode",
"io.netty.util.internal.shaded.org.jctools.queues.MpmcArrayQueueConsumerIndexField",
"io.netty.util.internal.shaded.org.jctools.queues.MpmcArrayQueueProducerIndexField",
"io.netty.util.internal.shaded.org.jctools.queues.MpscArrayQueueConsumerIndexField",
"io.netty.util.internal.shaded.org.jctools.queues.MpscArrayQueueProducerIndexField",
"io.netty.util.internal.shaded.org.jctools.queues.MpscArrayQueueProducerLimitField",
"io.netty.util.internal.shaded.org.jctools.util.UnsafeAccess",
"io.netty.util.internal.shaded.org.jctools.util.UnsafeLongArrayAccess",
"io.netty.util.internal.shaded.org.jctools.util.UnsafeRefArrayAccess",
"io.netty.util.internal.shaded.org.jctools.queues.unpadded.MpscUnpaddedArrayQueueConsumerIndexField",
"io.netty.util.internal.shaded.org.jctools.queues.unpadded.MpscUnpaddedArrayQueueProducerIndexField",
"io.netty.util.internal.shaded.org.jctools.queues.unpadded.MpscUnpaddedArrayQueueProducerLimitField",
"org.apache.arrow.memory.ArrowBuf",
"org.apache.arrow.memory.util.ByteFunctionHelpers",
"org.apache.arrow.memory.util.MemoryUtil",
"org.apache.arrow.memory.util.MemoryUtil\$1",
"org.apache.arrow.memory.util.hash.MurmurHasher",
"org.apache.arrow.memory.util.hash.SimpleHasher",
"org.apache.arrow.vector.BaseFixedWidthVector",
"org.apache.arrow.vector.BitVectorHelper",
"org.apache.arrow.vector.Decimal256Vector",
"org.apache.arrow.vector.DecimalVector",
"org.apache.arrow.vector.util.DecimalUtility",
"org.apache.arrow.vector.util.VectorAppender"
)
}
1 change: 0 additions & 1 deletion libs/arrow-spi/licenses/arrow-format-17.0.0.jar.sha1

This file was deleted.

This file was deleted.

This file was deleted.

This file was deleted.

1 change: 0 additions & 1 deletion libs/arrow-spi/licenses/arrow-vector-17.0.0.jar.sha1

This file was deleted.

8 changes: 0 additions & 8 deletions libs/arrow-spi/licenses/jackson-databind-LICENSE.txt

This file was deleted.

20 changes: 0 additions & 20 deletions libs/arrow-spi/licenses/jackson-databind-NOTICE.txt

This file was deleted.

Loading
Loading