Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Register UnmodifiableOnRestore settings #17121

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

anntians
Copy link
Contributor

Description

This PR builds on another PR. In the other PR we added a new Setting property UnmodifiableOnRestore to prevent settings from being modified on restore, but we weren't able to add the property to several settings because they were not yet registered. So this PR registers those settings with UnmodifiableOnRestore

Related Issues

Resolves Issue 2334 in KNN repository: opensearch-project/k-NN#2334
#17019

Check List

  • Functionality includes testing.
  • API changes companion pull request created, if applicable.
  • Public documentation issue/PR created, if applicable.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Copy link
Contributor

✅ Gradle check result for 49fc11a: SUCCESS

Copy link

codecov bot commented Jan 25, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 72.22%. Comparing base (931c1aa) to head (49fc11a).
Report is 5 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main   #17121      +/-   ##
============================================
- Coverage     72.30%   72.22%   -0.09%     
+ Complexity    65482    65395      -87     
============================================
  Files          5309     5309              
  Lines        304324   304350      +26     
  Branches      44132    44141       +9     
============================================
- Hits         220056   219813     -243     
- Misses        66259    66529     +270     
+ Partials      18009    18008       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant