Add support for append only indices #17039
Conversation
|
❌ Gradle check result for 38061f7: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
RS146BIJAY
requested review from
anasalkouz,
andrross,
ashking94,
Bukhtawar,
CEHENKLE,
dblock,
dbwiddis,
gbbafna,
jed326,
kotwanikunal,
mch2,
msfroh,
nknize,
owaiskazi19,
reta,
Rishikesh1159,
sachinpkale,
saratvemulapalli,
shwetathareja,
sohami,
VachaShah,
jainankitk and
linuxpi
as code owners
RS146BIJAY
changed the title
RS146BIJAY
force-pushed
the
append-only-indices
branch
from
38061f7 to
7af2713
Compare
|
❌ Gradle check result for 7af2713: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
libs/common/src/main/java/org/opensearch/common/IndexingRetryException.java
Outdated
Show resolved
Hide resolved
server/src/main/java/org/opensearch/action/bulk/TransportBulkAction.java
Outdated
Show resolved
Hide resolved
server/src/main/java/org/opensearch/action/bulk/TransportBulkAction.java
Outdated
Show resolved
Hide resolved
server/src/main/java/org/opensearch/action/bulk/TransportBulkAction.java
Outdated
Show resolved
Hide resolved
server/src/main/java/org/opensearch/action/bulk/TransportBulkAction.java
Outdated
Show resolved
Hide resolved
server/src/main/java/org/opensearch/action/bulk/TransportBulkAction.java
Show resolved
Hide resolved
server/src/internalClusterTest/java/org/opensearch/action/bulk/AppendOnlyIndicesIT.java
Show resolved
Hide resolved
RS146BIJAY
force-pushed
the
append-only-indices
branch
from
7af2713 to
694c524
Compare
|
❌ Gradle check result for 694c524: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Signed-off-by: RS146BIJAY <[email protected]>
RS146BIJAY
force-pushed
the
append-only-indices
branch
from
694c524 to
140d2b7
Compare
|
❌ Gradle check result for 140d2b7: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
| } else { | ||
| location = null; | ||
| } | ||
| } else if (indexResult.getSeqNo() != SequenceNumbers.UNASSIGNED_SEQ_NO |
There was a problem hiding this comment.
This also expects indexResult.getFailure() to be not null apart from not instance check of the new exception.
Should we change it to following (as used in line 962) to be safe ?
!(indexResult.getFailure() != null && (indexResult.getFailure() instanceof IndexingRetryException))
Description
Adding support for Append only indices where we are disabling any form of updates and deletes on the index. We are also preventing passing a custom doc id for bulk indexing requests. Append only indices will be supported through a configurable setting. If this setting is enabled, all update and delete operations on the index (UPDATE, DELETE, UPSERT, UPDATE BY QUERY, DELETE BY QUERY, etc,) will be blocked.
Related Issues
#12886
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.