Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Experimental gRPC server #16534

Draft
wants to merge 36 commits into
base: main
Choose a base branch
from
Draft

Experimental gRPC server #16534

wants to merge 36 commits into from
+1,118 −63

Conversation

finnegancarroll
Copy link
Contributor

@finnegancarroll finnegancarroll commented Oct 31, 2024 •
edited
Loading

Description

Experimental gRPC server.
Initial implementation includes only default health check service.

Feature flag: opensearch.experimental.feature.grpc.enabled

Related Issues

Resolves #[Issue number to be closed when this PR is merged]

Check List

  • Functionality includes testing.
  • API changes companion pull request created, if applicable.
  • Public documentation issue/PR created, if applicable.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@finnegancarroll
grpc gradle dependencies
fd39955 
Signed-off-by: Finn Carroll <[email protected]>
@finnegancarroll
Draft for grpc transport from network plugin impl
fe4f62d 
Signed-off-by: Finn Carroll <[email protected]>
@finnegancarroll
grpc needs defs from com.google.errorprone:error_prone_annotations
080de02 
Signed-off-by: Finn Carroll <[email protected]>
@finnegancarroll
guava to runtime dep
a894746 
Signed-off-by: Finn Carroll <[email protected]>
@finnegancarroll
Remove redundant overrides
3c05d8d 
Signed-off-by: Finn Carroll <[email protected]>
@finnegancarroll
Start grpc server
82bead3 
Signed-off-by: Finn Carroll <[email protected]>
@finnegancarroll
Add gprc settings
1dc81fc 
Signed-off-by: Finn Carroll <[email protected]>
@finnegancarroll
Channel related params not needed for grpc
331a1e9 
Signed-off-by: Finn Carroll <[email protected]>
@finnegancarroll
Worker count from settings
08967e7 
Signed-off-by: Finn Carroll <[email protected]>
@finnegancarroll
For now use first port/bind host listed
99f0184 
Signed-off-by: Finn Carroll <[email protected]>
@finnegancarroll
Default grpc address
ead594b 
Signed-off-by: Finn Carroll <[email protected]>
@finnegancarroll
Initial bind logic for netty grpc
648ab97 
Signed-off-by: Finn Carroll <[email protected]>
@finnegancarroll
Use GrpcTransportSettings - fix port in use bug
d007b72 
Signed-off-by: Finn Carroll <[email protected]>
@finnegancarroll
Add perms for gRPC ports
e7b16ea 
Signed-off-by: Finn Carroll <[email protected]>
@finnegancarroll
Add default health check service, perfmark - update gradle deps
ad0f8f9 
Signed-off-by: Finn Carroll <[email protected]>
@finnegancarroll
Add grpc info
77cd64f 
Signed-off-by: Finn Carroll <[email protected]>
@finnegancarroll
Move dep management to libs.versions.toml
cf219c4 
Signed-off-by: Finn Carroll <[email protected]>
@finnegancarroll
Refactor resolvePublishPort to NetworkService
44272d0 
Signed-off-by: Finn Carroll <[email protected]>
@finnegancarroll
Feature flag GRPC_ENABLE_SETTING
6134c17 
Signed-off-by: Finn Carroll <[email protected]>
@finnegancarroll
Add interceptor for grpc server stats
f9c5382 
Signed-off-by: Finn Carroll <[email protected]>
@finnegancarroll
grpc stats interceptor to final
4272dee 
Signed-off-by: Finn Carroll <[email protected]>
@finnegancarroll
Add grpc dep sha1s
b5fddb1 
Signed-off-by: Finn Carroll <[email protected]>
@github-actions GitHub Actions
Copy link
Contributor

❌ Gradle check result for b5fddb1: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@github-actions GitHub Actions
Copy link
Contributor

❌ Gradle check result for 24a40ad: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@finnegancarroll finnegancarroll mentioned this pull request Nov 4, 2024
Open
7 tasks
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 7, 2024

❌ Gradle check result for 3bcd5bb: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@finnegancarroll
Add GrpcInfo to node info api
b2a1078 
Signed-off-by: Finn Carroll <[email protected]>
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 7, 2024

❌ Gradle check result for b2a1078: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 8, 2024

❌ Gradle check result for ee85066: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peternied peternied Awaiting requested review from peternied peternied will be requested when the pull request is marked ready for review peternied is a code owner

@anasalkouz anasalkouz Awaiting requested review from anasalkouz anasalkouz will be requested when the pull request is marked ready for review anasalkouz is a code owner

@andrross andrross Awaiting requested review from andrross andrross will be requested when the pull request is marked ready for review andrross is a code owner

@ashking94 ashking94 Awaiting requested review from ashking94 ashking94 will be requested when the pull request is marked ready for review ashking94 is a code owner

@Bukhtawar Bukhtawar Awaiting requested review from Bukhtawar Bukhtawar will be requested when the pull request is marked ready for review Bukhtawar is a code owner

@CEHENKLE CEHENKLE Awaiting requested review from CEHENKLE CEHENKLE will be requested when the pull request is marked ready for review CEHENKLE is a code owner

@dblock dblock Awaiting requested review from dblock dblock will be requested when the pull request is marked ready for review dblock is a code owner

@dbwiddis dbwiddis Awaiting requested review from dbwiddis dbwiddis will be requested when the pull request is marked ready for review dbwiddis is a code owner

@gbbafna gbbafna Awaiting requested review from gbbafna gbbafna will be requested when the pull request is marked ready for review gbbafna is a code owner

@jainankitk jainankitk Awaiting requested review from jainankitk jainankitk will be requested when the pull request is marked ready for review jainankitk is a code owner

@kotwanikunal kotwanikunal Awaiting requested review from kotwanikunal kotwanikunal will be requested when the pull request is marked ready for review kotwanikunal is a code owner

@linuxpi linuxpi Awaiting requested review from linuxpi linuxpi will be requested when the pull request is marked ready for review linuxpi is a code owner

@mch2 mch2 Awaiting requested review from mch2 mch2 will be requested when the pull request is marked ready for review mch2 is a code owner

@msfroh msfroh Awaiting requested review from msfroh msfroh will be requested when the pull request is marked ready for review msfroh is a code owner

@nknize nknize Awaiting requested review from nknize nknize will be requested when the pull request is marked ready for review nknize is a code owner

@owaiskazi19 owaiskazi19 Awaiting requested review from owaiskazi19 owaiskazi19 will be requested when the pull request is marked ready for review owaiskazi19 is a code owner

@reta reta Awaiting requested review from reta reta will be requested when the pull request is marked ready for review reta is a code owner

@Rishikesh1159 Rishikesh1159 Awaiting requested review from Rishikesh1159 Rishikesh1159 will be requested when the pull request is marked ready for review Rishikesh1159 is a code owner

@sachinpkale sachinpkale Awaiting requested review from sachinpkale sachinpkale will be requested when the pull request is marked ready for review sachinpkale is a code owner

@saratvemulapalli saratvemulapalli Awaiting requested review from saratvemulapalli saratvemulapalli will be requested when the pull request is marked ready for review saratvemulapalli is a code owner

@shwetathareja shwetathareja Awaiting requested review from shwetathareja shwetathareja will be requested when the pull request is marked ready for review shwetathareja is a code owner

@sohami sohami Awaiting requested review from sohami sohami will be requested when the pull request is marked ready for review sohami is a code owner

@VachaShah VachaShah Awaiting requested review from VachaShah VachaShah will be requested when the pull request is marked ready for review VachaShah is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@finnegancarroll