Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Remote Publication] Add rolling upgrade bwc with remote publication enabled #16505

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

shiv0408
Copy link
Member

Description

Add bwc test in rolling upgrade with remote publication enabled.

Check List

  • Functionality includes testing.
  • API changes companion pull request created, if applicable.
  • Public documentation issue/PR created, if applicable.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Copy link
Contributor

❌ Gradle check result for 1fa4eb2: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Signed-off-by: Shivansh Arora <[email protected]>
Copy link
Contributor

❕ Gradle check result for 953282e: UNSTABLE

Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure.

Copy link

codecov bot commented Oct 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 72.12%. Comparing base (6f1b59e) to head (953282e).
Report is 5 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main   #16505      +/-   ##
============================================
+ Coverage     72.02%   72.12%   +0.09%     
- Complexity    65000    65091      +91     
============================================
  Files          5313     5313              
  Lines        303397   303397              
  Branches      43902    43902              
============================================
+ Hits         218528   218816     +288     
+ Misses        66982    66621     -361     
- Partials      17887    17960      +73     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

verifyTemplateMetadataInClusterState(response);
verifyComponentTemplateInClusterState(response);
verifyComposableTemplateInClusterState(response);
// Settings are required to wiped after Tests, so Settings are not present after rolling upgrade starts
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Which settings are wiped? But remote publication enabled setting is being verified above.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added few persistent and transient settings in the old version cluster, but we clean up the settings after test is run to run other tests.

if (preserveClusterSettings() == false) {
wipeClusterSettings();
}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants