-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Remote Publication] Add rolling upgrade bwc with remote publication enabled #16505
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: Shivansh Arora <[email protected]>
❌ Gradle check result for 1fa4eb2: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Signed-off-by: Shivansh Arora <[email protected]>
❕ Gradle check result for 953282e: UNSTABLE Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #16505 +/- ##
============================================
+ Coverage 72.02% 72.12% +0.09%
- Complexity 65000 65091 +91
============================================
Files 5313 5313
Lines 303397 303397
Branches 43902 43902
============================================
+ Hits 218528 218816 +288
+ Misses 66982 66621 -361
- Partials 17887 17960 +73 ☔ View full report in Codecov by Sentry. |
verifyTemplateMetadataInClusterState(response); | ||
verifyComponentTemplateInClusterState(response); | ||
verifyComposableTemplateInClusterState(response); | ||
// Settings are required to wiped after Tests, so Settings are not present after rolling upgrade starts |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Which settings are wiped? But remote publication enabled setting is being verified above.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added few persistent and transient settings in the old version cluster, but we clean up the settings after test is run to run other tests.
OpenSearch/test/framework/src/main/java/org/opensearch/test/rest/OpenSearchRestTestCase.java
Lines 583 to 585 in 08dc3bb
if (preserveClusterSettings() == false) { | |
wipeClusterSettings(); | |
} |
Description
Add bwc test in rolling upgrade with remote publication enabled.
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.