Add opensearch version info while deserialization

[soosinha]

Description

Custom Metadata is serialized writeTo and deserialized using the readFrom method or a constructor with stream input.
For example - ComposableIndexTemplate is serialized using ComposableIndexTemplate.writeTo and deserialized using the stream input constructor.
Consider a case where a new attribute is added in a version. For example context is added in ComposableIndexTemplate from 2.16 onwards. When it serialized from cluster manager of 2.15 version, the context field will not be present. But when the 2.16 cluster manager deserializes the object, it expects context field to be present and breaks.
The fix is to set the opensearch version in the stream input so that the deserialization will not look for new fields.

Related Issues

NA

Check List

• Functionality includes testing.
• API changes companion pull request created, if applicable.
• Public documentation issue/PR created, if applicable.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

[github-actions]

❌ Gradle check result for f98da36: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

[github-actions]

✅ Gradle check result for 7a49332: SUCCESS

[codecov]

Codecov Report

Attention: Patch coverage is 80.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 72.18%. Comparing base (6f1b59e) to head (4bd03a7).

Files with missing lines	Patch %	Lines
...ch/gateway/remote/RemoteGlobalMetadataManager.java	0.00%	1 Missing ⚠️

Additional details and impacted files

@@             Coverage Diff              @@
##               main   #16494      +/-   ##
============================================
+ Coverage     72.02%   72.18%   +0.15%     
- Complexity    65000    65117     +117     
============================================
  Files          5313     5313              
  Lines        303397   303400       +3     
  Branches      43902    43902              
============================================
+ Hits         218528   219010     +482     
+ Misses        66982    66429     -553     
- Partials      17887    17961      +74     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[github-actions]

❌ Gradle check result for e448dd3: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

[github-actions]

✅ Gradle check result for 64c813f: SUCCESS

[Bukhtawar]

Let's use a specific version rather than CURRENT. How does it work for 2.16 given it is already released and the version might not have been added at the time of serialisation.

[soosinha]

How does it work for 2.16 given it is already released and the version might not have been added at the time of serialisation.

It would be broken for 2.16 and 2.17 as well.

[soosinha]

I have used Version.CURRENT because the serialization is always done using the current version. So we have to deserialize using the current version as well in the unit tests.
I am thinking if we can write a BWC integ test where we can verify deserialization from older version.

[shwetathareja]

I am thinking if we can write a BWC integ test where we can verify deserialization from older version.

there was BWC tested added in mixed mode upgrade test for context aware template fielf. We should check what was missed there. @mgodwan @soosinha

[shwetathareja]

in this case it will serialize with which version?

[soosinha]

serialize will always happen with current version only

[shwetathareja]

@soosinha lets add mixed version mode test if it doesn't exist.

[github-actions]

✅ Gradle check result for 4bd03a7: SUCCESS

[soosinha]

Created an issue to track mixed version tests: #16497