-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade com.google.api-client to v2 #16156 #16460
base: main
Are you sure you want to change the base?
Conversation
@cwperks, please let me know if there is something add. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #16460 +/- ##
============================================
+ Coverage 72.03% 72.04% +0.01%
- Complexity 64998 65012 +14
============================================
Files 5313 5313
Lines 303293 303293
Branches 43886 43886
============================================
+ Hits 218476 218519 +43
+ Misses 66863 66831 -32
+ Partials 17954 17943 -11 ☔ View full report in Codecov by Sentry. |
@Yashovardhan08 for DCO amend your commit with |
@Yashovardhan08 The PR looks good to me, but can you also remove the entry from here as well? |
@Yashovardhan08 Can you also add an entry into the CHANGELOG in the Dependencies section? |
Also, DCO check is failing sadly :( |
Hi @Yashovardhan08, please update |
Description
Update to v2 for com.google.api-client dependency.
Related Issues
Related Issue: #[16156]
Related Issue:16072
Developer's Certificate of Origin 1.1
By making a contribution to this project, I certify that:
(a) The contribution was created in whole or in part by me and I
have the right to submit it under the open source license
indicated in the file; or
(b) The contribution is based upon previous work that, to the
best of my knowledge, is covered under an appropriate open
source license and I have the right under that license to
submit that work with modifications, whether created in whole
or in part by me, under the same open source license (unless
I am permitted to submit under a different license), as
Indicated in the file; or
(c) The contribution was provided directly to me by some other
person who certified (a), (b) or (c) and I have not modified
it.
(d) I understand and agree that this project and the contribution
are public and that a record of the contribution (including
all personal information I submit with it, including my
sign-off) is maintained indefinitely and may be redistributed
consistent with this project or the open source license(s)
involved.