Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support prefix list for remote repository attributes #16271

Merged

Conversation

rajiv-kv
Copy link
Contributor

@rajiv-kv rajiv-kv commented Oct 10, 2024

Description

Introduce a new constant remote_publication in RemoteStoreAttribute and allow the remote repositories configured using the additional prefix. A node can be configured with either of the prefix attributes remote_store.<repository-type>.repository.* (or) remote_publication.<repository-type>.repository.* based on its type. This will allow in migrating a remote publication cluster from remote store to local.

Related Issues

Resolves #[16390]

Check List

  • Functionality includes testing.
  • API changes companion pull request created, if applicable.
  • Public documentation issue/PR created, if applicable.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Copy link
Contributor

❌ Gradle check result for 5ff9010: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link
Contributor

❌ Gradle check result for 338e30e: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link
Contributor

❌ Gradle check result for 7390f52: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link
Contributor

❌ Gradle check result for f8b668c: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link
Contributor

❌ Gradle check result for bbc8d87: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link
Contributor

❌ Gradle check result for 0792965: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link
Contributor

❌ Gradle check result for 915ea10: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link
Contributor

❌ Gradle check result for cf74258: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@rajiv-kv rajiv-kv changed the title refactor the repository attribute keys Support prefix list for remote repository attributes Oct 18, 2024
Copy link
Contributor

❌ Gradle check result for a98a5de: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link
Contributor

✅ Gradle check result for c65085e: SUCCESS

Copy link

codecov bot commented Oct 19, 2024

Codecov Report

Attention: Patch coverage is 91.17647% with 12 lines in your changes missing coverage. Please review.

Project coverage is 72.12%. Comparing base (10873f1) to head (efbddfa).
Report is 10 commits behind head on main.

Files with missing lines Patch % Lines
...rch/node/remotestore/RemoteStoreNodeAttribute.java 89.90% 3 Missing and 8 partials ⚠️
...ensearch/index/remote/RemoteIndexPathUploader.java 80.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main   #16271      +/-   ##
============================================
- Coverage     72.15%   72.12%   -0.03%     
- Complexity    65145    65232      +87     
============================================
  Files          5315     5318       +3     
  Lines        303573   303890     +317     
  Branches      43925    43968      +43     
============================================
+ Hits         219039   219177     +138     
- Misses        66587    66778     +191     
+ Partials      17947    17935      -12     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rajiv-kv rajiv-kv marked this pull request as ready for review October 22, 2024 15:36
@rajiv-kv
Copy link
Contributor Author

@rajiv-kv please update the issue description in terms of what is the issue you are addressing in this PR.

Updated the description

Copy link
Contributor

✅ Gradle check result for c103127: SUCCESS

Copy link
Contributor

✅ Gradle check result for d0cb67e: SUCCESS

@rajiv-kv rajiv-kv force-pushed the repo_prefix_key_attributes branch 2 times, most recently from 31ac8d1 to 1ce13fc Compare October 28, 2024 08:05
Copy link
Contributor

❌ Gradle check result for 1ce13fc: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link
Contributor

✅ Gradle check result for 2f95c0f: SUCCESS

@shwetathareja shwetathareja added the backport 2.x Backport to 2.x branch label Nov 12, 2024
Copy link
Contributor

❌ Gradle check result for 615008f: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Signed-off-by: Rajiv Kumar Vaidyanathan <[email protected]>
Copy link
Contributor

✅ Gradle check result for a64284d: SUCCESS

Copy link
Contributor

✅ Gradle check result for efbddfa: SUCCESS

@shwetathareja shwetathareja merged commit 548a650 into opensearch-project:main Nov 13, 2024
38 checks passed
@opensearch-trigger-bot
Copy link
Contributor

The backport to 2.x failed:

The process '/usr/bin/git' failed with exit code 128

To backport manually, run these commands in your terminal:

# Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/OpenSearch/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/OpenSearch/backport-2.x
# Create a new branch
git switch --create backport/backport-16271-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 548a6505d6eaa88170462ef5eaf45a89a367126e
# Push it to GitHub
git push --set-upstream origin backport/backport-16271-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/OpenSearch/backport-2.x

Then, create a pull request where the base branch is 2.x and the compare/head branch is backport/backport-16271-to-2.x.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants