Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

List of deprecated code removal in 3.0 #2773

Open
5 of 19 tasks
anasalkouz opened this issue Apr 5, 2022 · 2 comments
Open
5 of 19 tasks

List of deprecated code removal in 3.0 #2773

anasalkouz opened this issue Apr 5, 2022 · 2 comments
Labels
deprecate enhancement Enhancement or improvement to existing feature or request v3.0.0 Issues and PRs related to version 3.0.0

Comments

@anasalkouz
Copy link
Member

anasalkouz commented Apr 5, 2022 •
edited by reta
Loading

This is a list to track all deprecated code or old usages that need to be removed on 3.0.
@anasalkouz anasalkouz added enhancement Enhancement or improvement to existing feature or request Meta Meta issue, not directly linked to a PR deprecate v3.0.0 Issues and PRs related to version 3.0.0 labels Apr 5, 2022
@anasalkouz anasalkouz mentioned this issue Apr 18, 2022
Closed
19 tasks
@kotwanikunal kotwanikunal assigned adnapibar and unassigned adnapibar Apr 18, 2022
@dreamer-89
Copy link
Member

Type mapping removal: #2979

This was referenced Apr 27, 2022
Closed
Open
@adnapibar adnapibar self-assigned this May 4, 2022
@tlfeng tlfeng mentioned this issue Jun 8, 2022
Open
4 tasks
@tlfeng tlfeng mentioned this issue Nov 11, 2022
Open
@adnapibar adnapibar removed their assignment Mar 3, 2023
@fmassot fmassot mentioned this issue May 10, 2023
Open
@lukas-vlcek
Copy link
Contributor

lukas-vlcek commented Sep 25, 2023 •
edited
Loading

Given that both the CamelCase nGram and edgeNGram tokenFilter names (and tokenizers) are deprecated (in favour to lower_case_with_underscore) then why is PathHierarchyTokenizer left in both the preConfiguredTokenizers and tokenizers under both keys path_hierarchy and PathHierarchy without any exceptions or deprecation logging?

See CommonAnalysisModulePlugin.java for details.

Is this just an issue or is there any reasoning behind this decision? Shall I open a ticket?

@lukas-vlcek lukas-vlcek mentioned this issue Oct 24, 2023
Merged
5 tasks
@reta reta changed the title [META] List of deprecated code removal List of deprecated code removal in 3.0.0 Nov 15, 2023
@reta reta changed the title List of deprecated code removal in 3.0.0 List of deprecated code removal in 3.0 Nov 15, 2023
@reta reta mentioned this issue Nov 15, 2023
Open
19 tasks
@reta reta removed the Meta Meta issue, not directly linked to a PR label Nov 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
deprecate enhancement Enhancement or improvement to existing feature or request v3.0.0 Issues and PRs related to version 3.0.0
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@lukas-vlcek @reta @adnapibar @anasalkouz @dreamer-89