Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactoring #180

Merged
merged 12 commits into from
Jan 19, 2025
Merged

Refactoring #180

merged 12 commits into from
Jan 19, 2025

Conversation

AHReccese
Copy link
Member

@AHReccese AHReccese commented Jan 14, 2025

Reference Issues/PRs

#147 #44 #45

What does this implement/fix? Explain your changes.

Any other comments?

@AHReccese AHReccese added minor minor changes, to be reviewed in max 5 days refactoring labels Jan 14, 2025
@AHReccese AHReccese added this to the pymilo v1.2 milestone Jan 14, 2025
@AHReccese AHReccese self-assigned this Jan 14, 2025
@AHReccese
Copy link
Member Author

AHReccese commented Jan 14, 2025

@sepandhaghighi Feel free to review CLI and recently added parts (I mean not necessarily modification in this PR) and drop any comment you may have.

Copy link
Member

@sepandhaghighi sepandhaghighi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🔥

@sepandhaghighi
Copy link
Member

@AHReccese Feel free to Squash/Merge this pull request! 🔥

@AHReccese AHReccese merged commit 07ce47a into dev Jan 19, 2025
25 checks passed
@AHReccese AHReccese deleted the refactoring branch January 19, 2025 17:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
minor minor changes, to be reviewed in max 5 days refactoring
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature]: CLI for PyMilo Server Refactoring2 (Performance) Refactoring1 (Code Style)
2 participants