Garbage collector for old glide_XXXX dirs #369
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bbockelm
reviewed
Feb 6, 2025
| } | ||
|
|
||
| // Filter dirs | ||
| for _, dir := range dirs { |
There was a problem hiding this comment.
Could you switch this to be based on WalkFunc?
I like WalkFunc better because it doesn't require us to completely iterate through the directory -- significantly reduces the load on the filesystem and reduces what's buffered in memory.
There was a problem hiding this comment.
If we want a random pick, I think we have to build the complete list of candidates first (which means full listing, and stating).
One option would be to relax that requirement, use WalkFunc, and select the candidates one by one. However, I suspect this mean the removal happens in lexical order and that could be problematic if we have multiple active glideins.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.