Quick hack on the example for web rendering #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This let's the user essentially have the ability to edit and render from the browser. The user can also download the STL
Pushed the previous commit a little too early
|
I think this is good to go as a base example of using three.js and OpenSCAD-wasm. Let me know what you think. I tried to mimic the OpenSCAD GUI a little bit. It has room to improve. Some nice todos would be
|
|
Just noting there's https://ochafik.com/openscad/# ... |
DSchroer
reviewed
May 4, 2022
There was a problem hiding this comment.
Hey. Sorry about the late reply. I am happy to add the example. Just one small comment on the code. My only question is if this is the right spot for these project. I see this as a building block for other sites and not so much as a place to put implementations around it. What do you think?
| @@ -14,14 +51,162 @@ | |||
| link.remove(); | |||
| }; | |||
|
|
|||
| const instance = await OpenScad({ noInitialRun: true }); | |||
| // const material = new THREE.MeshPhysicalMaterial({ | |||
There was a problem hiding this comment.
Do you mind removing the commented out code before I merge?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Still needs a bit of work to optimize and make cleaner. This allows a user of the web example to render the generated model and download it.
Additionally I added a textbox so users can edit in the browser and render as they go.
A JS linter will be needed to make this useful and not just "not work" on bad scad files