Update rubocop: 0.52.1 → 0.60.0 (major) #138
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![depfu[bot]](https://avatars.githubusercontent.com/in/715?s=60&v=4){kind=small}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We've updated a dependency and here is what you need to know:
Additionally, the update changed a few other dependencies as well:
You should probably take a good look at the info here and the test results before merging this pull request, of course.
What changed?
✳️ rubocop (0.52.1 → 0.60.0) · Repo · Changelog
Release Notes
0.60.0
New features
--safeand--safe-auto-correctoptions. (@Darhazer)--auto-gen-only-exclude. (@Ana06, @jonas054)VersionAddedmeta data to config/default.yml when runningrake new_cop. (@koic)Whitelistconfig toRails/SkipsModelValidationsrule. (@DiscoStarslayer)Bug fixes
Rails/ReversibleMigrationwhen using variable assignment. (@koic, @scottmatthewman)Style/RedundantFreezeand a false negative forStyle/MutableConstantwhen assigning a regexp object to a constant. (@koic)Style/RedundantFreezewhen assigning a range object to a constant. (@koic)Rails/ReversibleMigrationwhen block argument is empty. (@koic)LineLengthcop for tab-indented code. (@AlexWayfer)Changes
keyoption inLayout/AlignHashcop. (@albaer)0.59.2
Bug fixes
Rails/HasManyOrHasOneDependentwhen using associations of Active Resource. (@tejasbubane, @koic)Style/Forwhen settingEnforcedStyle: eachandfordose not havedoor semicolon. (@autopp)Layout/EmptyLineAfterGuardClausewhen guard clause including heredoc. (@koic)AllowURIoption forMetrics/LineLengthcop with disabledLayut/Tabcop. (@AlexWayfer)Metrics/BlockLengthinto the respective length cops. (@drenmi)Style/ZeroLengthPredicatefalse positives when inspectingTempfile,StringIO, andFile::Statobjects. (@drenmi)Layout/EmptyLinesAroundAccessModifierandLayout/EmptyLinesAroundAccessModifierwhen specifying a superclass that breaks the line. (@koic)Style/IfUnlessModifierwhen using named capture. (@drenmi)Style/Semicolonfrom breaking on single line if-then-else in assignment. (@drenmi)Rails/HasManyOrHasOneDependentwhen an Active Record model does not have any relations. (@koic)Style/Forwhen settingEnforcedStyle: eachwith range provided to theforloop without adokeyword or semicolon and without enclosing parenthesis. (@lukasz-wojcik)Changes
Metrics/MethodLength. (@akanoi)0.59.1
Bug fixes
Rails/FindEach. (@Knack)Naming/FileNamewhen investigating gemspecs. (@kddeisz)Naming/FileNamewhen investigating dotfiles. (@sinsoku)Style/EmptyCaseConditionauto-correction removes comment betweencaseand firstwhen. (@koic)Style/RedundantBeginwhen callingsuperwith a block. (@eitoball)Layout/EmptyLineAfterGuardClausewhen guard clause is after heredoc including string interpolation. (@koic)Style/MultilineMethodSignature. (@drenmi)Layout/EmptyLineAfterGuardClausecop whenifcondition is after heredoc. (@koic)Changes
Lint/UnreachableCodedetectexit,exit!andabort. (@hoshinotsuyoshi)#===fromNaming/BinaryOperatorParameterName. (@zverok)+to allowed file names ofNaming/FileName. (@yensaki)0.59.0
New features
Bundler/GemCommentcop. (@sunny)IgnoredMethodsoption toStyle/NumericPredicatecop. (@AlexWayfer)--display-only-fail-level-offensesto only output offenses at or above the fail level. (@robotdana)Style/For. (@rrosenblum)AllowImplicitReturnoption toRails/SaveBangcop. (@robotdana)comparisonstyle toStyle/NilComparison. (@khiav223577)Style/MultilineMethodSignaturecop. (@drenmi)Performance/ChainArrayAllocationcop. (@schneems)Layout/EmptyLinesAroundClassBodyaware of specifying a superclass that breaks the line. (@koic)Bug fixes
Style/DateTimenot detecting#to_datetime. It can be configured to allow this. (@bdewater)Naming/FileNamewhenIncludeofAllCopsis the default setting. (@koic)Layout/MultilineOperationIndentation. (@jonas054)Layout/ClosingParenthesisIndentationwhen method arguments are empty with newlines. (@tatsuyafw)Layout/AccessModifierIndentationwhen using access modifiers with arguments within nested classes. (@gmalette)Style/IfUnlessModifiercop for disabledLayout/Tabcop when there is noIndentationWidthconfig. (@AlexWayfer)AllowURIoption ofMetrics/LineLengthcop for files with tabs indentation. (@AlexWayfer)Style/UnneededConditionwhen using operator method higher precedence than||. (@koic)Lint/ShadowedArgument. (@jonas054)Layout/MultilineHashBraceLayoutandLayout/MultilineArrayBraceLayoutauto-correct syntax error when there is a comment on the last element. (@bacchir)Style/BracesAroundHashParametersauto-correct syntax error when there is a trailing comma. (@bacchir)Style/RedundantBeginaware of stabby lambdas. (@drenmi)Naming/PredicateName. (@sunny)Style/EmptyCaseConditionwhen usingreturninwhenclause and assigning the return value ofcase. (@koic)Rails/Delegate. (@sunny)Style/WordArraywhen settingEnforcedStyle: bracketsand using string interpolation in%Wliteral. (@koic)Lint/RescueEnsureAlignmentwhenendis misaligned. The alignment and message are now based on the beginning position rather than theendposition. (@rrosenblum)Dateusage inStyle/DateTime. (@deivid-rodriguez)Changes
Rails/FindEachcop. Makes the cop also check for the following scopes:eager_load,includes,joins,left_joins,left_outer_joins,preload,references, andunscoped. (@repinel)dbto allowed names ofNaming/UncommunicativeMethodParamNamecop in default config. (@mkenyon)Lint/DuplicateMethodsto include the method name. (@rrosenblum)rubocop --auto-gen-confif the todo file is successfully created even if there are offenses. (@MagedMilad)Rails/RelativeDateConstantby default. (@koic)*) to match the hidden file. (@koic)Style/Fornow highlights the entire statement rather than just the keyword. (@rrosenblum)Performance/CaseWhenSplatand its auto-correction by default. (@rrosenblum)Layout/EmptyLineAfterGuardClausecop by default. (@koic)Style/DateTimehas been moved to disabled by default. (@deivid-rodriguez)0.58.2
Changes
New features
#6105: Support
{a,b}file name globs inExcludeandIncludeconfig. (@mikeyhew)#6116: Add
ipto allowed names ofNaming/UncommunicativeMethodParamNamecop in default config. (@nijikon)Bug fixes
Layout/IndentationWidthwhen multiple modifiers are used in a block and a method call is made at end of the block. (@koic)Naming/MemoizedInstanceVariableNamecop to allow methods to have leading underscores. (@kenman345)Layout/ClassStructurewhen there is a comment in the macro method to be auto-correct. (@koic)Lint/OrderedMagicCommentswhen using{ encoding: Encoding::SJIS }hash object afterfrozen_string_literalmagic comment. (@koic)0.58.1
Bug fixes
Style/MethodCallWithArgsParentheseswhen arguments are method calls. (@maxh)Style/RedundantParentheseswith hash literal as first argument tosuper. (@maxh)Gemspec/OrderedDependencieswhen using method call to gem names in gemspec. (@koic)Rails/BulkChangeTableaware of variable table name. (@wata727)Layout/MultilineAssignmentLayoutcop when using multi-line block defines on separate lines. (@koic)0.57.2
Bug fixes
Layout/ClosingHeredocIndentationfrom raising an error on<<heredocs. (@dvandersluis)Layout/ClosingHeredocIndentationfrom raising an error on heredocs containing only a newline. (@drenmi)Layout/IndentationConsistencycop triggered by an empty expression string interpolation. (@alexander-lazarov)Style/MethodCallWithArgsParenthesesfrom raising an error in certain cases. (@drenmi)0.57.1
Bug fixes
inherit_modedirective. (@jonas054)Layout/IndentationWidthwhen an access modifier section has an invalid indentation body. (@tatsuyafw)Layout/IndentationConsistencyshould still register an offense for private methods. (@jaredbeck)Rails/BulkChangeTable. (@wata727)Style/UnneededConditioncop accepts a case of condition andif_branchare same when usingelsifbranch. (@koic)0.57.0
New features
Rails/BulkChangeTablecop. (@wata727)Style/AccessModifierDeclarationscop. (@brandonweiss)Style/UnneededConditioncop. (@balbesina)Layout/ClosingHeredocIndentationcop. (@siggymcfried)slashesstyle toRails/FilePathsince Ruby accepts forward slashes even on Windows. (@sunny)Layout/LeadingBlankLineschecks for empty lines at the beginning of a file. (@rrosenblum)Bug fixes
Style/SymbolArrayandStyle/WordArraynot working on arrays of size 1. (@TikiTDO)Rails/AssertNotto allow it to have failure message. (@koic)headersorenvkeyword arguments inRails/HttpPositionalArguments. (@rrosenblum)Style/BracesAroundHashParametersauto-correct going past the end of the file when the closing curly brace is on the last line of a file. (@EiNSTeiN-)Style/FrozenStringLiteralCommentwould be added to the second line if the first line is empty. (@rrosenblum)Layout/SpaceInsideReferenceBracketsaware ofno_spacewhen using nested reference brackets. (@koic)Style/MixinGroupingwhen method namedincludeaccepts block. (@Darhazer)Changes
--fix-layout/-xcommand line alias. (@scottmatthewman)Lint/SplatKeywordArgumentscop. (@koic)httpdateto acceptedRails/TimeZonemethods. (@cupakromer)xmlschemato acceptedRails/TimeZonemethods. (@koic)rake repltask tobin/consolecommand. (@koic)inherit_modework for default configuration too. (@jonas054)unicode/display_width. (@nroman-stripe)0.56.0
New features
Performance/InefficientHashSearchcop. (@JacobEvelyn)Rails/RefuteMethodscop. (@koic)Rails/AssertNotcop. (@composerinteralia)Layout/ClosingParenthesisIndentationdetection including method chaining. (@jfelchner)consistent_relative_to_receiverstyle option toLayout/FirstParameterIndentation. (@jfelchner)AR::Migration#up_onlyforRails/ReversibleMigrationcop. (@koic)Lint/ErbNewArgumentscop. (@koic)Lint/SplatKeywordArgumentscop. (@koic)Include,Excludeand the newRubyInterpretersparameters for file selection. (@jonas054)Bug fixes
Style/EmptyMethodwhich concatenated the method name and first argument if no method def parentheses are used. (@thomasbrus)Rails/SaveBangwhen using negated if. (@Edouard-chin)Lint/SafeNavigationChainnot detecting chained operators after block. (@Darhazer)Lint/SafeNavigationConsistencyregisters multiple offenses for the same method call. (@rrosenblum)Style/CommentAnnotationreporting only the first of multiple consecutive offending lines. (@svendittmer)Lint/SafeNavigationConsistencywhen there is code around the condition. (@rrosenblum)Rails/HasManyOrHasOneDependentwhen using nestedwith_options. (@koic)--stdinalways treats input as Ruby source irregardless of filename. (@PointlessOne)Style/MethodCallWithArgsParenthesesadding extra parentheses if the method argument was already parenthesized. (@dvandersluis)AllCops/Includewere not inspected when passing the file name as an option. (@drenmi)Lint/PercentStringArrayandLint/PercentSymbolArraywhen the inspected file is binary encoded. (@akhramov)nilresponds to inLint/SafeNavigationConsistency. (@rrosenblum)Lint/LiteralInInterpolationif contains numbers. (@koic)Rails/CreateTableWithTimestampswhen using hash options. (@wata727)Lint/UnneededCopEnableDirectivefor instruction '# rubocop:enable all'. (@balbesina)Rails/HttpPositionalArgumnetsto usesessioninstead ofheader. (@rrosenblum)Changes
Style/MethodMissinginto two cops,Style/MethodMissingSuperandStyle/MissingRespondToMissing. (@rrosenblum)AllowInMultilineConditionsoption toStyle/ParenthesesAroundConditioncop. (@Darhazer)Layout/SpaceInsideReferenceBracketswhen assigning a reference bracket to a reference bracket. (@joshuapinter)--auto-correct. (@jonas054)try!to the list of whitelisted methods forLint/SafeNavigationChainandStyle/SafeNavigation. (@rrosenblum)Style/EmptyLineAfterGuardClausecop toLayoutdepartment. (@koic)Not all release notes shown. View the full release notes
Commits
See the full diff on Github. The new version differs by more commits than we can show here.
Commits
See the full diff on Github. The new version differs by 66 commits:
Update changelog.Bump version.- lexer.rl: Partially revert 5ba072d and properly handle 'm = -> *args do end'.Update changelog.Bump version.Fix YARD type annotations for parameterized typesFix YARD type annotation for nilable typesFix doc typoRevert parsing of '-> do rescue; end' for ruby25, it's valid only starting from 26. (#510)- lexer.rl: Fix parsing of 'm = -> *args do end'.Update changelog.- AST::Processor: Properly recurse into "kwsplat" nodes+ ruby26.y: Endless ranges support.- ruby24, ruby25, ruby26: Fix cmdargs after command_args followed by tLBRACE_ARG.- lexer.rl: Fix parsing of `let (:a) { m do; end }`.Fix a wrong indentation in the AST_FORMAT.mdUpdate changelog.Bump version.- lexer.rl, Dedenter: Treat slash in heredocs as a line continuation.- lexer.rl: Fix parsing of `a ? b + '': nil`.- lexer.rl: Reject `m a: {} {}` and `m [] {}` since 25.* Parser::Current: bump latest 2.2 branch to 2.2.10.Parser::Current: bump latest versions to 2.3.7, 2.4.4, 2.5.1. (#489)call String#getbyte- builders/default: allow class/module/dynamic constant definition in the method body if there's a sclass between them. (bug #490)- lexer.rl: Emit :!@ as :!, :~@ as :~.- parse{23,24,25}.y: use only CMDARG/COND _PUSH/POP for cmdarg/cond management. (bug #481)+ ruby26.y: Raise a syntax error on 'else' without 'rescue'.- lexer.rl: emit tSTRING_BEG and tSTRING_DBEG one by one to allow parser to properly manipulate cmdarg stack. (bug #480)ruby26.y: branch parser.Bump version.Update changelog.Bump version.Moved @last_token capturing from Lexer#emit to Parser#next_token.ruby-parse displays escape sequences only in tty- AST::Processor: handle on_index, on_indexasgn, on_lambda.Fix cmdarg handling around string interpolation. (#467)Update changelog.Allow bundler 1.15 (Debian unstable).Bump version.Update changelog.- Accept `BEGIN` and `END` as correct method name (#463)Remove duplicate test case in test_source_tree_rewriter.rb (#462)Fix cmdarg handling for parsers < 24.Make sure Source::Buffer#name is a stringFix Out of range error reportingFix wording [ci-skip]- Parser::Source::Buffer: Fixed parsing of encoding comment when the file contains only shebang.Bump warning message for 2.4.x branch in the parser/current.call String#b instead of #dup+#force_encodingBump version.- ruby24.y, ruby25.y: Replicate cmdargs handling from MRI. (#453)Update changelog.Bump version.Fix running `rake changelog` on tagged commit.- parser/current: latest released Ruby series is 2.5.x.- builders/default: x[], x[]=1: emit as s(:index), s(:indexasgn) via AST opt-in.+ builders/default: __ENCODING__: emit as s(:__ENCODING__) via AST opt-in.- lexer.rl: "#{-> foo {}}": fix parsing of interpolated lambda with open args.Fixed encoding comment handling.Fixed cmdarg manipulation in command_args rule.+ ruby25.y: Extract expr_value_do rule.+ ruby25.y: Extract begin_block rule.+ ruby25.y: Allow class and method definition in the while condition. (#432)+ ruby25: Allow `-> do rescue; end`. (#431)Update changelog.Commits
See the full diff on Github. The new version differs by 13 commits:
Cut 0.1.2[Fix #27] Don't return nils from remove_prefix and remove_suffix[Fix #34] Revert "Fixing the tests and the definition of sum"Bump the yard dependencyUpdate Enumerable#sum to match the builtin (#35)Update Travis config (#36)Add jruby-9.1.13.0 to the TravisCI matrix (#31)Use SVG badges in the README [ci skip] (#32)Fixing the tests and the definition of sumFixing rbxUpdate the TravisCI configUse the ISO date format in the changelogAdd some contribution guidelinesCommits
See the full diff on Github. The new version differs by 12 commits:
Release v1.4.0Unicode 11Release v1.3.3Clarify supported RubiesReplace Gem::Util.gunzip with direct zlib implementationRelease v1.3.2Explicitly load rubygems/util, fixes regression in 1.3.1 (autoload issue)Release v1.3.1Update travis rubiesMerge pull request #15 from Schwad/masterUpdates 'Gem.gunzip' to 'Gem::Util.gunzip'Update travis rubiesDepfu will automatically keep this PR conflict-free, as long as you don't add any commits to this branch yourself. You can also trigger a rebase manually by commenting with
@depfu rebase.All Depfu comment commands