-
Notifications
You must be signed in to change notification settings - Fork 7
Update releasing-files.md #433
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
amirmehrkar
wants to merge
6
commits into
main
Choose a base branch
from
amirmehrkar-patch-1
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
f989880
Update releasing-files.md
amirmehrkar 2b81d4a
Update releasing-files.md
amirmehrkar 29e3ab2
Update releasing-files.md
amirmehrkar ed6fed6
Update releasing-files.md
amirmehrkar 811e368
Update releasing-files.md
amirmehrkar 76cc008
Update releasing-files.md
amirmehrkar File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -5,10 +5,10 @@ The final tier is review of so-called "Level 4" outputs, where the OpenSAFELY fr | |
If you have Level 4 access you can log in and review your aggregated results, and perform any necessary redactions before requesting files to be released. | ||
You will find your files to review in `D:\Level4Files\workspaces\<workspacename>`. | ||
|
||
Level 4 outputs **can only be released by specific members of the OpenSAFELY team**. When you are ready to request a release of your aggregated results, and only the minimum outputs necessary (for which you have also applied any necessary disclosure controls, such as small number suppression) **please [complete this form](documents/OpenSAFELY_Output_Review_Form.docx) and email us at <[email protected]>**. | ||
Level 4 outputs **can only be released by specific members of the OpenSAFELY team**. When you are ready to request an OUTPUT REVIEW and RELEASE of your aggregated results, and only the minimum outputs necessary (for which you have also applied any necessary disclosure controls, such as small number suppression) **please [complete this form](documents/OpenSAFELY_Output_Review_Form.docx) and email us at <[email protected]>**. | ||
|
||
!!! warning | ||
** Data may only be shared with individuals without Level 4 access after they have been released outside of the secure area. You MUST NOT screen share (or share via any other means) any results that have not been released through the official process.** | ||
** Data may only be shared IN CONFIDENCE with wider members of the research team, including external collaborators, after they have been released outside of the secure Level 4 area. You MUST NOT screen share (or share via any other means) any results from the Level 4 environment that have not been submitted for OUTPUT REVIEW. See below for publication guidance.** | ||
|
||
!!! warning | ||
** DO NOT release your aggregated study results to your GitHub repository yourself (unless you have been given permission by OpenSAFELY).** | ||
|
@@ -41,6 +41,20 @@ It may be possible for exceptions to be made if they can be justified as being b | |
|
||
**If you are unsure about anything, please email us: <[email protected]>.** | ||
|
||
## Publication of your study results (released from the Level 4 environment) and GitHub repository | ||
|
||
### Study results | ||
Once the Level 4 outputs have been released (as per the above process), you can share the data **in confidence** with wider members of the research team, including external collaborators. For example, the study author may copy the outputs from the GitHub repository to a document being prepared for publication, or to seek feedback and contribution from other colleagues to inform the final paper or report. | ||
|
||
However, **for publication (e.g. MedRxiv), or circulation of the findings outside of the immediate research team or collaborators** (e.g. presentations given to interested groups), the final paper/report/presentation (etc.), including a brief lay summary of the important conclusions, **must first be emailed to <[email protected]> who will seek final approval for release from NHS England.** The purpose of this approval step is to check that the paper/report aligns with the stated application purpose. | ||
|
||
### Study GitHub repository | ||
|
||
Similarly, **the study repository must be kept private until project completion and NHS England approval has been obtained**; however, the OpenSAFELY Oversight Board has recommended that all study GitHub repositories (to include the study definition code, codelists and released results) be make public 12 months after any code has been executed against the underlying patient data. | ||
|
||
!!! warning | ||
** YOU MUST NOT publish any results or circulate findings with any interested groups outside of the immediate research team / collaborators, or make public your study GitHub repository, until you have received approval from NHS England. To obtain approval email <[email protected]> with your paper/report/presentation including a brief lay summary of the important conclusions.** | ||
|
||
## Redaction data breaches and how to recover from them | ||
|
||
### The issues | ||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This isn't quite right, if the repository doesn't contain any outputs - right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes but for now we have this dual process where it might have outputs (as we havent fully moved to jobserver output process). Once we have we we can change this/ remove this. I thought after we discussed we were covering ourselves for this issue for now.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
needs to marry up with point 7 on latest Data Access Agreement want to send out too https://docs.google.com/document/d/1Kf8vL1Gy8t_AJgTTOcPtwl1vlBNQSCu855Bd4JUoL9I/edit so if we change this (which is fine), need to update the DAA too.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please HOLD OFF on this commit
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We may have another solution that need to work up and discuss with Ben and Seb Tuesday