Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial version of ehrQL cheatsheet #2239

Merged
merged 3 commits into from
Nov 22, 2024
Merged

Initial version of ehrQL cheatsheet #2239

merged 3 commits into from
Nov 22, 2024

Conversation

madwort
Copy link
Contributor

@madwort madwort commented Nov 20, 2024

  • basics of setting up a file
  • list of tables / columns
  • condensed version of the existing examples page
  • some other function reference bits

Copy link

cloudflare-workers-and-pages bot commented Nov 20, 2024

Deploying databuilder-docs with  Cloudflare Pages  Cloudflare Pages

Latest commit: b81a9f5
Status: ✅  Deploy successful!
Preview URL: https://9484a190.databuilder.pages.dev
Branch Preview URL: https://madwort-cheatsheet.databuilder.pages.dev

View logs

@madwort madwort mentioned this pull request Nov 20, 2024
@madwort madwort linked an issue Nov 20, 2024 that may be closed by this pull request
@madwort madwort removed a link to an issue Nov 20, 2024
Copy link
Contributor

@rebkwok rebkwok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, some minor comments/questions

docs/reference/cheatsheet.md Show resolved Hide resolved
patients.date_of_death
```

### tpp
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if the list of tables/columns is the one place where a link to the reference docs would be useful and not clutter?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah, it depends on format - I started with a markdown file like this & had the same thought as you, then I switched to a printed page layout & thought it would be useful, now it's back as a long markdown page it seems less valuable, I'd like to leave it for now & maybe reformat the page to more of the sort of shape that I'd expect from a cheatsheet (the main criteria being that a large proportion of the content is visible simultaneously)

docs/reference/cheatsheet.md Outdated Show resolved Hide resolved
docs/reference/cheatsheet.md Outdated Show resolved Hide resolved
@madwort madwort enabled auto-merge (squash) November 22, 2024 20:52
@madwort madwort merged commit d3d5f0b into main Nov 22, 2024
8 checks passed
@madwort madwort deleted the madwort/cheatsheet branch November 22, 2024 21:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants