Update HttpSender.Request.Builder to support multipart/form-data request bodies with multiple parts
#5044
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…est bodies with multiple parts
bryceatmoderne
changed the title
HttpSender.Request.Builder to support multipart/form-data request bodies with multiple parts
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Some suggestions could not be made:
- rewrite-hcl/src/main/java/org/openrewrite/hcl/format/TabsAndIndentsVisitor.java
- lines 255-256
- rewrite-hcl/src/main/java/org/openrewrite/hcl/internal/HclPrinter.java
- lines 363-364
- rewrite-java/src/main/java/org/openrewrite/java/internal/template/AnnotationTemplateGenerator.java
- lines 158-159
- rewrite-java/src/main/java/org/openrewrite/java/internal/template/BlockStatementTemplateGenerator.java
- lines 281-282
- lines 669-669
- rewrite-java/src/main/java/org/openrewrite/java/search/FindEmptyClasses.java
- lines 57-57
- rewrite-xml/src/main/java/org/openrewrite/xml/internal/XmlPrinter.java
- lines 106-106
- rewrite-yaml/src/main/java/org/openrewrite/yaml/cleanup/RemoveUnusedVisitor.java
- lines 76-76
pstreef
approved these changes
Feb 14, 2025
| @@ -129,11 +127,13 @@ public String toString() { | |||
|
|
|||
| @SuppressWarnings("UnusedReturnValue") | |||
| public static class Builder { | |||
| private static final String APPLICATION_JSON = "application/json"; | |||
| private static final String TEXT_PLAIN = "text/plain"; | |||
| public static final String APPLICATION_JSON = "application/json"; | |||
There was a problem hiding this comment.
This is exposed for tests I think? Can you make these package private instead?
| /** | ||
| * Adds a part to a multipart/form-data request body. | ||
| * | ||
| * @param type The "Content-Type" of the part. |
There was a problem hiding this comment.
maybe rename it to contentType?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's changed?
Update
HttpSender.Request.Builderto support building multipart/form-data request bodies with multiple parts.What's your motivation?
This functionality is required for CLI feature development.
Anything in particular you'd like reviewers to focus on?
No.
Anyone you would like to review specifically?
@pstreef
Have you considered any alternatives or workarounds?
No.
Any additional context
No.
Checklist