Add ResolutionEventListener event whenever a repository normalization attempt is skipped
#5023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…on attempt is skipped When a normalization attempt fails, the repository gets cached as `null` and any subsequent normalization attempts are skipped. When this cache is persisted we lose any such information in subsequent runs. Adding this event can give a hint as to why repositories are not attempted for downloading.
timtebeek
approved these changes
Feb 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a normalization attempt fails, the repository gets cached as
nulland any subsequent normalization attempts are skipped. When this cache is persisted we lose any such information in subsequent runs. Adding this event can give a hint as to why repositories are not attempted for downloading.What's changed?
New event added and used
What's your motivation?
Not knowing why a repository is not attempted to be used for downloading
Have you considered any alternatives or workarounds?
It would be even nicer of downloadError could list all the repositories NOT attempted (with reasons), but that would be a much bigger change.