Fix AddOrUpdateAnnotationAttribute unable to handle FieldAccess #4898
Conversation
|
Hi @SiBorea I also stumbled across this a few hours ago, thanks for the fix. If you have any questions regarding my comments, feel free to ask. :) |
| @@ -893,6 +892,47 @@ public class A { | |||
| ); | |||
| } | |||
|
|
|||
| @Test | |||
| void updateFieldAccessAttribute() { | |||
| rewriteRun( | |||
There was a problem hiding this comment.
Can you try to apply the recipe to change the value from hello to Cost.HI?
There was a problem hiding this comment.
The attributeValue of the recipe is of type String, don't think we can change the value from hello to Const.HI
There was a problem hiding this comment.
I tested it a little bit, the result shows that it can only change the value to "Const.HI", not Const.HI
There was a problem hiding this comment.
It should be possible. The attributeValue's value is interpreted as whatever it is. Did you try the FQN Const.HI?
If you don't mind, I would have a look myself.
There was a problem hiding this comment.
Sure, please go ahead.
rewrite-java/src/main/java/org/openrewrite/java/AddOrUpdateAnnotationAttribute.java
Outdated
Show resolved
Hide resolved
rewrite-java/src/main/java/org/openrewrite/java/AddOrUpdateAnnotationAttribute.java
Outdated
Show resolved
Hide resolved
| } else if (exp instanceof J.FieldAccess) { | ||
| as = JavaTemplate.builder("#{} = #{}") | ||
| .build() | ||
| .apply(new Cursor(getCursor(), as), as.getCoordinates().replace(), var.getSimpleName(), newAttributeValue); |
There was a problem hiding this comment.
Why do you think you need a new Cursor here? getCursor() should do the trick
There was a problem hiding this comment.
Using getCursor() here will return a J.Annotation object, rather than J.FieldAccess we need.
There was a problem hiding this comment.
A I see, thats right. Within this recipe the situation is solved by generating an new Annotation with one Assigment and then call get(0), see
rewrite-java/src/main/java/org/openrewrite/java/AddOrUpdateAnnotationAttribute.java
Outdated
Show resolved
Hide resolved
# Conflicts: # rewrite-java/src/main/java/org/openrewrite/java/AddOrUpdateAnnotationAttribute.java
What's changed?
Checklist