Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add explicit imports to avoid conflicts with classes added to java.lang, like record #4785

Conversation

BramliAK
Copy link
Contributor

@BramliAK BramliAK commented Dec 15, 2024

What's changed?

Add explicit imports to avoid conflicts with classes added to java.lang, like record

Checklist

  • I've added unit tests to cover both positive and negative cases
  • I've read and applied the recipe conventions and best practices
  • I've used the IntelliJ IDEA auto-formatter on affected files

@timtebeek timtebeek self-requested a review December 15, 2024 09:38
@timtebeek timtebeek changed the title Rewrite migrate java issue 540 : add explicit imports to avoid conflicts with classes added to java.lang, like record Add explicit imports to avoid conflicts with classes added to java.lang, like record Dec 15, 2024
Copy link
Contributor

@timtebeek timtebeek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the helpful change here @BramliAK ! Indeed seems like the right place to make this change, and we can now follow up with a recipe in rewrite-migrate-java that adds explicit imports as needed for fix openrewrite/rewrite-migrate-java#540.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants