Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Extend message on http sender response #4355

Closed

Conversation

pstreef
Copy link
Contributor

@pstreef pstreef commented Jul 25, 2024

Adding a body when it makes sense (server/client exceptions) and cause message if available (although this is unused in this repo).

Adding a body when it makes sense (server/client exceptions) and cause message if available (although this is unused in this repo).
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some suggestions could not be made:

  • rewrite-gradle/src/main/groovy/RewriteSettings.groovy
    • lines 31-36
  • rewrite-xml/src/main/java/org/openrewrite/xml/style/AutodetectDebug.java
    • lines 68-68
    • lines 109-111
    • lines 134-134
    • lines 147-149

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some suggestions could not be made:

  • rewrite-gradle/src/main/groovy/RewriteSettings.groovy
    • lines 31-36
  • rewrite-xml/src/main/java/org/openrewrite/xml/style/AutodetectDebug.java
    • lines 68-68
    • lines 109-111
    • lines 134-134
    • lines 147-149

@pstreef
Copy link
Contributor Author

pstreef commented Jul 25, 2024

this has some uninteded side-effects. Going to close it for now

@pstreef pstreef closed this Jul 25, 2024
@timtebeek timtebeek deleted the feat/extended-message-on-http-sender-response-exception branch January 14, 2025 10:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants