Ignore method invocation arguments that are not string J.Literals #4276
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timtebeek
approved these changes
Jun 20, 2024
crankydillo
pushed a commit
to crankydillo/rewrite
that referenced
this pull request
Jul 11, 2024
…enrewrite#4276) Fixes: openrewrite#4275 Co-authored-by: Jente Sondervorst <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #4275
What's changed?
A check before casting. If it is not a string, it is most likely not a dependency notation.
What's your motivation?
In line with: "Do not change anything if we are not sure", I propose to just give back this argument as is without touching.
Any additional context
This is actually not meant to be coded like this in gradle, yet it is working unfortunately and has been copy/pasted througout some of our repo's.
Checklist