Only allow Gradle AddDependency
to add dependencies to the top-level dependencies
block
#4181
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's changed?
Due to the Groovy compiler misinterpreting receiver classes for the
dependencies
block, this can result in thegradle.AddDependency
recipe placing new dependencies improperly.What's your motivation?
Anything in particular you'd like reviewers to focus on?
Just the pattern of using a
Predicate
from the recipe standpoint as the mechanism with which to invert the control flow and allow more specific insertion points from a dependency standpoint.Anyone you would like to review specifically?
Anybody who wants to double check the work.
Have you considered any alternatives or workarounds?
None
Any additional context
None
Checklist