Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Option to add classifier to managed dependency #3831

Closed
wants to merge 4 commits into from

Conversation

timtebeek
Copy link
Contributor

What's changed?

Added @Option Boolean includeManaged to .../maven/ChangeDependencyClassifier.

What's your motivation?

Fixes #3830

Anyone you would like to review specifically?

@melloware

Have you considered any alternatives or workarounds?

Separate recipe seems too heavy-handed;

Any additional context

TODO

  • Only add in managed when present
  • Possibly do the same for Gradle

@timtebeek timtebeek added the enhancement New feature or request label Dec 16, 2023
@timtebeek timtebeek self-assigned this Dec 16, 2023
@timtebeek
Copy link
Contributor Author

Not quite pleased with this approach yet: ideally we detect if a dependency is managed (in a pom part of the git repository), and only then add the classifier there, without passing in an explicit option toggle. 🤔

Copy link

@melloware melloware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like this better than not having it at all!

@timtebeek
Copy link
Contributor Author

I'm going to close this attempt; the downside of having something sub-optimal is that folks will build it into their own recipes, making it hard to remove. I think instead we should opt for detecting if a dependency is managed, and if so add the classifier to the managed dependency if we can, and if we can not then add the classifier where it's used instead. I'll close this attempt for now .

@timtebeek timtebeek closed this Apr 30, 2024
@timtebeek timtebeek deleted the add-classifier-to-managed-dependencies branch April 30, 2024 10:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Maven: Add ChangeManagedDependencyClassifier
2 participants