Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clarified messaging of methodType checks in FindMissingTypes. #3808

Merged
merged 3 commits into from
Dec 13, 2023
Merged

Clarified messaging of methodType checks in FindMissingTypes. #3808

merged 3 commits into from
Dec 13, 2023

Conversation

traceyyoshima
Copy link
Contributor

Changes:

  • Clarified the message where differences in method types are identified in FindMissingTypes.

timtebeek
timtebeek reviewed Dec 13, 2023
View reviewed changes
Copy link
Contributor

@timtebeek timtebeek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A small suggestion to change the wording, as referentially object didn't quite come across clearly for me. I hope the new wording is actually correct though, so feel free to correct me on that still.

rewrite-java/src/main/java/org/openrewrite/java/search/FindMissingTypes.java Outdated Show resolved Hide resolved
rewrite-java/src/main/java/org/openrewrite/java/search/FindMissingTypes.java Outdated Show resolved Hide resolved
@traceyyoshima traceyyoshima merged commit eb423e5 into main Dec 13, 2023
@traceyyoshima traceyyoshima deleted the update-assertion-messages branch December 13, 2023 22:00
@timtebeek timtebeek added the documentation Improvements or additions to documentation label Dec 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timtebeek timtebeek timtebeek left review comments

Assignees

@traceyyoshima traceyyoshima

Labels
documentation Improvements or additions to documentation
Projects
OpenRewrite
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@traceyyoshima @timtebeek