refactor: OpenRewrite recipe best practices #3799
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use this link to re-run the recipe: https://app.moderne.io/recipes/builder/XX1hrwagC?organizationId=T3BlblJld3JpdGU%3D Co-authored-by: Moderne <[email protected]>
|
This is a first run ahead of automated enforcement of recipe runs against new pull requests, to minimize the changes produced. |
knutwannheden
requested changes
Dec 8, 2023
| @@ -99,7 +99,8 @@ void removeUnappliedPluginWithoutVersion() { | |||
| void applySyntax() { | |||
| rewriteRun( | |||
| spec -> spec.recipe(new RemoveBuildPlugin("org.openrewrite.rewrite")), | |||
| buildGradle(""" | |||
| buildGradle( | |||
| """ | |||
There was a problem hiding this comment.
Looks like the indentation is still a bit off (6 instead of just 2).
There was a problem hiding this comment.
Hmm; doesn't seem feasible to resolve from IDE, given the number of files and changes; even a quick attempt with IntelliJ then throws up more unrelated changes, so then perhaps best not to apply this one here just yet.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use this link to re-run the recipe: https://app.moderne.io/recipes/builder/XX1hrwagC?organizationId=T3BlblJld3JpdGU%3D